FileStore now recreates parent cache folders if a write fails #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating fork
made and the cache file path no longer exists
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
thymikee
added a commit
to thymikee/metro
that referenced
this pull request
Mar 16, 2019
…ation * upstream/master: Upgrade jest to 24.5.0 Bump Prettier to 1.16.4 Bump Metro to v0.53.1 Another pass at Metro Flow annotation coverage Add CLI option to ignore function map Default to lazy requires for all public RN exports (facebook#362) FileStore now recreates parent cache folders if a write fails (facebook#370) Support symbolicating file:line:column stack frames Add connection verification Improve Flow annotation coverage in Metro Drop leading newline Deploy 0.94 to xplat Add new metro flag for running inspector proxy Perform security fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were seeing periodic cases of builds failing where a cache write would fail. The cause of this seems to be another process cleaning up the /tmp folder periodically - to reduce the chance of these failures this PR adds some fallback logic where if a filestore write fails it will try to recursively recreate its parent cache paths and try writing again.
Test plan
Run the new unit test and see that it passes after the FileStore change is made