Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-build emhermesc.js with GitHub Action #796

Closed

Conversation

robhogan
Copy link
Contributor

@robhogan robhogan commented Mar 23, 2022

Motivation

  • The current build instructions are out of date since Hermes required a two-stage build, and the suggested Docker base is deprecated.
  • It's currently very difficult to replicate/verify this build without Buck
  • It's a laborious process to update or review any updates to this file
  • There's no good way to know what version of Hermes the current emhermesc.js was built from.
  • We're overdue an update now, not least to fix the temporary patch in 4be4099

Change

See the diff on the Readme (TL;DR - this uses a GitHub action to perform the build based on hermes-github-ref, and auto-pushes to a PR / uploads the result / fails on a mismatch).

Test plan

I iterated this on my fork: https://github.com/rh389/metro

Job fails because the file is out of sync on main

https://github.com/rh389/metro/runs/5662424803?check_suite_focus=true
image

Job succeeds by pushing to a PR

robhogan#3
image

Artifacts are uploaded

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 23, 2022
@facebook-github-bot
Copy link
Contributor

@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robhogan
Copy link
Contributor Author

Closing this for now as there's some more work to do to find a nice workflow - it seems that we can't commit to forks from an action even when the PR author allows commits from maintainers.

@robhogan robhogan closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants