Skip to content

Commit

Permalink
Fix bwProbeWait_ calculation
Browse files Browse the repository at this point in the history
Summary: This was outright wrong. We need to wait 2-3 seconds.

Reviewed By: mjoras

Differential Revision: D53500129

fbshipit-source-id: bc270c950076919fd4fe8dbeb1b12c2d19d7ae15
  • Loading branch information
jbeshay authored and facebook-github-bot committed Feb 7, 2024
1 parent 1acec8e commit 8d14b97
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion quic/congestion_control/Bbr2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,8 @@ void Bbr2CongestionController::startProbeBwDown() {
/* Decide random round-trip bound for wait: */
roundsSinceBwProbe_ = folly::Random::rand32() % 2;
/* Decide the random wall clock bound for wait: between 2-3 seconds */
bwProbeWait_ = std::chrono::milliseconds(2 + folly::Random::rand32() % 1000);
bwProbeWait_ =
std::chrono::milliseconds(2000 + (folly::Random::rand32() % 1000));

probeBWCycleStart_ = Clock::now();
state_ = State::ProbeBw_Down;
Expand Down

0 comments on commit 8d14b97

Please sign in to comment.