Skip to content

Commit

Permalink
Fix comment on bandwidth sampler.
Browse files Browse the repository at this point in the history
Summary:
The comment is the reverse of the actual logic.  When app-limited, bandwidth samples are not considered valid, because the data being sent is being limited by the application and not the network.

Created from CodeHub with https://fburl.com/edit-in-codehub

Reviewed By: jbeshay

Differential Revision: D65976022

fbshipit-source-id: 0c52bab2edb560afe5e885b0df33090935490778
  • Loading branch information
Wesley Eddy authored and facebook-github-bot committed Nov 15, 2024
1 parent 1cc00f7 commit bea51cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion quic/congestion_control/BbrBandwidthSampler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ void BbrBandwidthSampler::onPacketAcked(
}
Bandwidth measuredBandwidth = sendRate > ackRate ? sendRate : ackRate;

// This is a valid sample if the packet was sent while app-limited or
// This is a valid sample if the packet was sent while not app-limited or
// it's higher than the current sample.
if (!ackedPacket.isAppLimited || measuredBandwidth > latestSample_) {
latestSample_ = measuredBandwidth;
Expand Down

0 comments on commit bea51cf

Please sign in to comment.