Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit use of FizzCryptoFactory from QuicClientTransport #71

Closed
wants to merge 1 commit into from

Conversation

deadalnix
Copy link
Contributor

One less use of Fizz in "shared" space.

Depends on #70

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 20, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yangchi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@yangchi merged this pull request in 24cedd8.

facebook-github-bot pushed a commit that referenced this pull request Nov 28, 2019
Summary:
Move things that depends on fizz down to FizzClientHandshake.

Depends on #71
Pull Request resolved: #72

Reviewed By: mjoras

Differential Revision: D18688622

Pulled By: yangchi

fbshipit-source-id: 54999355dfd907903d91bf9bc50239fb84ac2428
@deadalnix deadalnix deleted the nofizzcryptotransport branch November 28, 2019 22:39
facebook-github-bot pushed a commit that referenced this pull request Aug 1, 2022
Summary:
X-link: facebookresearch/Private-ID#71

Previous codemod left some crust. This commit cleans up useless uses to use less uses.

Reviewed By: stepancheg

Differential Revision: D38211793

fbshipit-source-id: c852dd1ec617fe81a1d9bd0d8a9e5d2357b9b502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants