10X faster predict by replacing DataFrame with dict

[orenmatar]

Profiling the predict code yielded this result:

Evidently about 90% of the predict time is spent on either the init of a DataFrame or its getitem method, both are notoriously slow.
A very simple change from dataframe to dict in sample_model and sample_model_vectorized has no risk and implications beyond sample_posterior_predictive since the df is converted to a dict there anyway.
Profiling after the change gives:

and in runtime it was reduced from ~300ml to ~38ml on a local test

[nicolaerosia]

@tcuongd can we please merge this and release a new version with wheels for python 3.11 as well?

[orenmatar]

@tcuongd any updates on this? It should be really easy to integrate and yields a big runtime improvement

[tcuongd]

Wow great find, thanks heaps! Yeah I think changing the return type for these internal functions is fine, we just need to make it clear which functions are affected in the release notes.

[tcuongd]

For some reason CI didn't kick off, I'll take a look later

[facebook-github-bot]

Hi @orenmatar!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[tcuongd]

@orenmatar Do you mind just signing the CLA? Thanks!

[orenmatar]

@tcuongd Signed it just now

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!