chore: Add iOS 17 textContentType types
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalkerco
changed the title
textContentType types
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 21, 2023
Summary: While setting up a credit card form in RN, I discovered that iOS 17 supports a number of new content types ([`UITextContentType` docs](https://developer.apple.com/documentation/uikit/uitextcontenttype?language=objc)). In the docs these are marked with the `Beta` flag. Setting up the new content types is relatively straightforward, but a change is required in https://github.com/facebook/react-native-deprecated-modules to update the `TextInput` prop types. ~~I will open a PR in that repo shortly.~~ I have [opened a PR](facebook/react-native-deprecated-modules#23) to update the prop types. ~~Once that PR is merged, a version bump for that dependency will need to be added to this PR.~~ The PR is merged and the dependency in this PR has been updated. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [ADDED] - Added support for iOS 17+ text content types For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #38354 Test Plan: The `rn-tester` app builds and runs successfully. I have added a few new examples of inputs using the new text content types. Reviewed By: javache Differential Revision: D47554161 Pulled By: philIip fbshipit-source-id: 8d4414dc6229063f81164f2d8727921c8294c92e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prop type change is required to support the new
textContentTypeandautoCompleteprop values that are being added in facebook/react-native#38354If/when this PR is merged and released, the associated react-native PR will need to have its
deprecated-react-native-prop-typesdependency updated to prevent prop type warnings.