Documentation Update for RN PR #30737 - Remove Android specifier for progressViewOffset prop. #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tList, RefreshControl, and VirtualizedList
|
✔️ Deploy preview for react-native ready! 🔨 Explore the source changes: b5e0142 🔍 Inspect the deploy logs: https://app.netlify.com/sites/react-native/deploys/60008b412729100007efacb4 😎 Browse the preview: https://deploy-preview-2441--react-native.netlify.app |
Simek
added
🕐 Waiting on PR
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 11, 2021
Summary: Fixes #10718, bringing `progressViewOffset` support to iOS. Thanks to Taylor123 for the initial PR upon which this fix is based. ## Changelog [iOS] [Fix] - `progressViewOffset` prop of `RefreshControl` and `VirtualizedList` now works on iOS Pull Request resolved: #30737 Test Plan: Tested with quick-and-dirty sample app.  ## Documentation The corresponding documentation update PR can be found [here](facebook/react-native-website#2441). Reviewed By: kacieb Differential Revision: D26813977 Pulled By: sammy-SC fbshipit-source-id: 45cc5a647d70e44a29c6391b7586cb41ca011bef
Simek
removed
the
🕐 Waiting on PR
Simek
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Hi @davidbiedenbach, thank you for posting this companion PR for the docs! 👍
Your PR has landed on master, and will be part of next release, so it's time to merge the changes. 🙂
savv
pushed a commit
to savv/react-native-savv
that referenced
this pull request
May 18, 2021
Summary: Fixes facebook#10718, bringing `progressViewOffset` support to iOS. Thanks to Taylor123 for the initial PR upon which this fix is based. ## Changelog [iOS] [Fix] - `progressViewOffset` prop of `RefreshControl` and `VirtualizedList` now works on iOS Pull Request resolved: facebook#30737 Test Plan: Tested with quick-and-dirty sample app.  ## Documentation The corresponding documentation update PR can be found [here](facebook/react-native-website#2441). Reviewed By: kacieb Differential Revision: D26813977 Pulled By: sammy-SC fbshipit-source-id: 45cc5a647d70e44a29c6391b7586cb41ca011bef (cherry picked from commit 310a6bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native PR 30737 introduces iOS support for the
progressViewOffsetprop inRefreshControl,FlatList, andVirtualizedList.This PR updates the documentation for those components to remove the
Androidspecifier.