Fix LogBox.ignoreAllLogs used with no argument (#29310)

Summary: When you call `LogBox.ignoreAllLogs()` it should ignore logs. This fixes a bug that made this equivalent to `LogBox.ignoreAllLogs(false)` ## Changelog [General] [Fixed] - LogBox.ignoreAllLogs() should ignore logs Pull Request resolved: #29310 Test Plan: Added tests Reviewed By: TheSavior Differential Revision: D22448436 Pulled By: rickhanlonii fbshipit-source-id: 6ba12b9d9c1f29cf3ac503946ac5ca0097425a7a
facebook · Jul 9, 2020 · f28c750 · f28c750
1 parent ffa3d7f
commit f28c750
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/Libraries/LogBox/LogBox.js b/Libraries/LogBox/LogBox.js
@@ -43,7 +43,7 @@ if (__DEV__) {
     },
 
     ignoreAllLogs: (value?: ?boolean): void => {
-      LogBoxData.setDisabled(!!value);
+      LogBoxData.setDisabled(value == null ? true : value);
     },
 
     uninstall: (): void => {

diff --git a/Libraries/LogBox/__tests__/LogBox-test.js b/Libraries/LogBox/__tests__/LogBox-test.js
@@ -69,6 +69,30 @@ describe('LogBox', () => {
     expect(LogBoxData.isDisabled()).toBe(true);
   });
 
+  it('will not ignore logs for `ignoreAllLogs(false)`', () => {
+    expect(LogBoxData.isDisabled()).toBe(false);
+
+    LogBox.install();
+
+    expect(LogBoxData.isDisabled()).toBe(false);
+
+    LogBox.ignoreAllLogs(false);
+
+    expect(LogBoxData.isDisabled()).toBe(false);
+  });
+
+  it('will ignore logs for `ignoreAllLogs()`', () => {
+    expect(LogBoxData.isDisabled()).toBe(false);
+
+    LogBox.install();
+
+    expect(LogBoxData.isDisabled()).toBe(false);
+
+    LogBox.ignoreAllLogs();
+
+    expect(LogBoxData.isDisabled()).toBe(true);
+  });
+
   it('registers warnings', () => {
     jest.mock('../Data/LogBoxData');