[iOS][cocoapods] 'RCTAnimation/RCTValueAnimatedNode.h' file not found

[skv-headless]

Description

'RCTAnimation/RCTValueAnimatedNode.h' file not found.
in current master https://github.com/facebook/react-native/tree/c233191485ef733aa7a8d4ea5c758b9e6a06964c

1. related to 28 of march changes. @janicduplessis might help
2. podspec test are passed. @alloy do you have ideas how tests could be improved?
   Maybe we need to run xcbuild to test?

Reproduction Steps and Sample Code

https://github.com/skv-headless/AwesomeProject - demo project based on this page https://facebook.github.io/react-native/docs/integration-with-existing-apps.html#cocoapods

Solution

It works if change #import <RCTAnimation/RCTValueAnimatedNode.h> to #import "RCTValueAnimatedNode.h"

Additional Information

• Platform: [iOS]
• Development Operating System: [MacOS]

[alloy]

podspec test are passed. @alloy do you have ideas how tests could be improved?
Maybe we need to run xcbuild to test?

Nah, we should ideally build all the subspecs, I’ll take a look at how long those take.

[alloy]

@skv-headless Your example fails to build from a fresh clone with different issues than the one this ticket is about. Can you make sure it fails with the exact issue you mention from a fresh clone (so no pod install, no npm install) ?

[alloy]

While enabling full podspec testing I did encounter this failure, which is probably the one you’re referring to:

In file included from /Users/eloy/Code/React/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.m:10:
/Users/eloy/Code/React/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h:12:9: fatal error: 'RCTAnimation/RCTValueAnimatedNode.h' file not found
#import <RCTAnimation/RCTValueAnimatedNode.h>

[skv-headless]

Yep. This error. I've updated repo in case it still needed. Are you going to update test script?

[alloy]

Yeah I’ll do that, and then we’ll see how much time it takes to complete on CI.

[alloy]

Pushed #13217

[shrutic]

I still get this error even in 0.44.0 where the code in RCTNativeAnimatedModule.h is updated from It works if change #import <RCTAnimation/RCTValueAnimatedNode.h> to #import "RCTValueAnimatedNode.h"

as mentioned by the original Bug logger. So the solution did not work for me.. Any other recommended solutions?

[iggyfisk]

This is fixed as of 7b7d6bb @skv-headless

[nartawak]

@iggyfisk Is it possible to have a 0.44 fix with this commit ?

[egorkhmelev]

For those who still searching for a quick solution. I was able to launch iOS app with RCTAnimation subspec by including following string to my package.json:

"scripts": {
  "postinstall": "sed -i '' 's\/#import <RCTAnimation\\/RCTValueAnimatedNode.h>\/#import \"RCTValueAnimatedNode.h\"\/' ./node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h",
  ...rest scripts
}

React: 16.0.0-alpha.12
ReactNative: 0.45.0-rc.0

Didn't work for me with above PR which already accepted in 0.45.0-rc.0

[comigor]

@egorkhmelev same for me. ss.header_dir on Podspec didn't solve this issue.

[nartawak]

@iggyfisk This PR (7b7d6bb) didn't solve this issue (with RN 0.45.0-rc.0) but this one which is closed yes (13217) !!!

Does someone work again on this issue ?

[guysegal]

this is a blocker for us too.. why is the issue closed? (13217)

[younatics]

Still get this error in RN 0.45.1

[djhr]

having this error too in v0.45.1

[stefanengel]

Getting the error in RN 0.45.1 as well

[younatics]

Please use this script in package.json script section.

"postinstall": "sed -i '' 's\/#import <RCTAnimation\\/RCTValueAnimatedNode.h>\/#import \"RCTValueAnimatedNode.h\"\/' ./node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h",

It will change #import <RCTAnimation/RCTValueAnimatedNode.h> -> #import "RCTValueAnimatedNode.h

[guysegal]

I use this script and it works but it's not a solution its a patch.. Also some of our teammates are working on Windows macines so this script will not work (I know there's an equivalent for Windows)

The point is that this should be solved the right way without using any hacking..

[younatics]

Right. Should be fixed

[guysegal]

it seem that this change in RCTNativeAnimatedNodesManager.h does the trick:

before:

after:

Does this make sense? It's working for me on 0.45.1, without running the patch script

[jlyonsmith]

What build is the React Native team planning to put out a fix for this? Now that Swift has been around for a couple years and use_frameworks! has become commonplace this seems like it really needs a fix. Maybe a trial branch so that folks can report errors and issues before release?

[rodrigoelp]

That is exactly my line. Doing an application completely in react native is practically unfeasible and most new software is been written in swift (and kotlin)

[p2k]

Duplicate declaration is inherently prevented by ObjC/clang's #import instruction, except if the headers do exist twice, which is prevented with my proposed approach.

[khadkaPratik]

@younatics Your trick worked but i have to remove node_modules folder add the script in package.json and npm install . It worked in my case. Thank you for the trick .

[orta]

Hi everyone, I've centralized a lot of the CocoaPods issues into a single project which will apply all of the post-install fixes for you, which should simplify integrating React Native with CocoaPods

https://github.com/orta/cocoapods-fix-react-native

[Abdul-Hannan]

its sad that even after an year, React-native iOS through Cocoapods is not seamless, you still have to patch around things

[jeanregisser]

What version are you on @Abdul-Hannan?
The project I'm currently working on uses CocoaPods with React Native 0.55.3 without any issue.

[Abdul-Hannan]

Hello @jeanregisser , I am using 0.55.4

just added the pods as usual, but got this issue

[jeanregisser]

Ok, and what version of CocoaPods?

[Abdul-Hannan]

I am using COCOAPODS: 1.5.0,
avoided issues by using @orta 's https://github.com/orta/cocoapods-fix-react-native

[react-native-bot]

Please try again with 0.56.0-rc and let us know if that does not resolve the issue by leaving a comment here.

[chrisballinger]

I can verify that RN 0.56.0-rc.2 does not resolve the issue.

[rodrigoelp]

Yup, it has not been fixed. This issue has been on for more than a year.

[keshavkaul]

@jeanregisser This is still an issue with RN 0.56.0-rc.4

pod 'React', :path => REACT_NATIVE_PATH, :subspecs => [
    'Core',
    'CxxBridge', # Include this for RN >= 0.47
    'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43
    'RCTAnimation',
    'RCTActionSheet',
    'RCTBlob',
    'RCTGeolocation',
    'RCTImage',
    'RCTLinkingIOS',
    'RCTNetwork',
    'RCTSettings',
    'RCTText',
    'RCTVibration',
    'RCTWebSocket'
  ]

  # Explicitly include Yoga if you are using RN >= 0.42.0
  pod 'yoga', :path => "#{REACT_NATIVE_PATH}/ReactCommon/yoga"

  # Third party deps podspec link
  pod 'DoubleConversion', :podspec => "#{REACT_NATIVE_PATH}/third-party-podspecs/DoubleConversion.podspec"
  pod 'glog', :podspec => "#{REACT_NATIVE_PATH}/third-party-podspecs/glog.podspec"
  pod 'Folly', :podspec => "#{REACT_NATIVE_PATH}/third-party-podspecs/Folly.podspec"

[pavjacko]

try to add this to package.json and run it in your post-install:

"scripts": {
  "fix:ios": "sed -i '' 's/#import <RCTAnimation\\/RCTValueAnimatedNode.h>/#import \"RCTValueAnimatedNode.h\"/' ./node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h"
}

Here is the project template which demonstrates this:
https://www.npmjs.com/package/react-native-vanilla

[ttruongatl]

I upgraded my react-native to v0.56.0. once I run pod install before building iOS. It works. My solution is

1. Update [email protected]
2. cd ios && pod install
3. react-native run-ios

[muhammadsr]

For those who are still experiencing the issue. Try the following:

1. rm -rf ~/Library/Developer/Xcode/DerivedData/
2. Inside the ios folder, do
   rm -rf "`pwd`/Pods/"
3. rm -rf "${HOME}/Library/Caches/CocoaPods"
4. Run pod install
5. Open xcworkspace
6. Product > Clean
7. Product > Clean Folder (Must hold the option key)
8. Build

Good luck!

[Dimon70007]

I am using COCOAPODS: 1.5.0,
avoided issues by using @orta 's https://github.com/orta/cocoapods-fix-react-native

This library only removes import strings. that were not automatically linked. It's not a solution to remove import code for fixing bugs because it may cause crash