Does this template bundle Flipper in release?

[henrymoulton]

https://github.com/react-native-community/react-native-template-typescript/blob/master/template/ios/HelloWorld/AppDelegate.m#L7

https://github.com/react-native-community/react-native-template-typescript/blob/master/template/ios/HelloWorld/AppDelegate.m#L7

In the main docs the #ifdef FB_SONARKIT_ENABLED is wrapped with #if DEBUG

https://fbflipper.com/docs/getting-started/react-native-ios#initialization

[safaiyeh]

I raised a PR for this in the past #29646

Conclusion is that we dont want to add if DEBUG, best to add it yourself if you need it

[cortinico]

Conclusion is that we dont want to add if DEBUG, best to add it yourself if you need it

Thanks for the clarification. Can we close this issue and the related PR #29646 then @safaiyeh ?

[henrymoulton]

I agree with the principle (maybe it can be refactored) but disagree with this conclusion, cc @alloy, I think we should try to align with the Flipper docs first and foremost, if the Flipper team think there should be changes (cc @mweststrate) they will be in the best place to make sure the RN template and the Flipper guidance is aligned.

[mweststrate]

I think FB_SONARKIT_ENABLED should already be only set in DEBUG, but allows for more fine grained control then just DEBUG? But tbh I'm not sure where FB_SONARKIT_ENABLED is defined atm inside React Native :)

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity.