Wrap iOS Flipper code with #if

[safaiyeh]

Summary

Fixes #29336

Flipper should only be instantiated when in DEBUG regardless if FB_SONARKIT_ENABLED is enabled.

Changelog

[iOS] [Changed] - Make sure Flipper only instantiated in DEBUG mode

Test Plan

Built the template app and Flipper integration still works

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,003,030	0
android	hermes	armeabi-v7a	6,666,643	0
android	hermes	x86	7,423,355	0
android	hermes	x86_64	7,314,247	0
android	jsc	arm64-v8a	9,162,798	0
android	jsc	armeabi-v7a	8,818,528	0
android	jsc	x86	9,011,190	0
android	jsc	x86_64	9,588,283	0

Base commit: 208ebed

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 208ebed

[alloy]

Why does FB_SONARKIT_ENABLED evaluate to true when it shouldn’t?

I think it’s less of an issue in this specific case, as this is at least in the user’s codebase, but I’m conceptually against gating any of these things based on DEBUG. I.e. it should be up to the dev to decide in what configuration this is enabled, but we can provide sane defaults of course.

[safaiyeh]

@alloy I feel like the FB_SONARKIT_ENABLED variable is a bit unclear to user land. The only use for it is for Flipper. While DEBUG makes more sense, as you wouldn't want Flipper integrated to your production app.

[alloy]

What about renaming the macro to eg FLIPPER_ENABLED?

[safaiyeh]

I like that better!

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR was closed because it has been stalled for 7 days with no activity.