Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VirtualizedList.js, fix wrong position after scrollToEnd when props.refreshing === true #14089

Closed
wants to merge 1 commit into from
Closed

Update VirtualizedList.js, fix wrong position after scrollToEnd when props.refreshing === true #14089

wants to merge 1 commit into from

Conversation

zongwan
Copy link
Contributor

@zongwan zongwan commented May 22, 2017

Pull request again for clean branch

Thanks for submitting a PR! Please read these instructions carefully:

  • Explain the motivation for making this change.
  • Provide a test plan demonstrating that the code is solid.
  • Match the code formatting of the rest of the codebase.
  • Target the master branch, NOT a "stable" branch.

Motivation (required)

What existing problem does the pull request solve?
Fix #14033
Fix wrong position after scrollToEnd when props.refreshing === true

Test Plan (required)

Before

before

After

after

Next Steps

Sign the CLA, if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.

For more info, see the "Pull Requests" section of our "Contributing" guidelines.

fix #14033
fix wrong position after `scrollToEnd` when `props.refreshing === true`
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels May 22, 2017
@sahrens
Copy link
Contributor

sahrens commented Jun 20, 2017

Sweet, thanks! I'm importing the scrollview fix too.

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jun 20, 2017
@facebook-github-bot
Copy link
Contributor

@sahrens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved. JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants