fix memory leak

[yk3372]

Signed-off-by: yk3372 [email protected]

Motivation (required)

What existing problem does the pull request solve?

ViewManagersPropertyCache, ViewManagerPropertyUpdater, MessageQueueThreadRegistry static field not release when ReactInstanceManager called destroy.

Test Plan (required)

I use this url to integrate RN:
http://facebook.github.io/react-native/docs/integration-with-existing-apps.html
and in Activity's onDestroy function add the follow code to release RN:

mReactInstanceManager.destroy();
mReactInstanceManager = null;

and then when I exit activity, find the static field not release.
the follow is screen shot:
before:

after:

[yk3372]

The MessageQueueThread maybe reference NativeModuleCallExceptionHandler, and NativeModuleCallExceptionHandler is inner class has CatalystInstanceImpl‘s reference.
This resulting in CatalystInstanceImpl can not release.
Except for the above, to release the static reference is no effect when destroy RN.

#14127

@javache

[yk3372]

Why the CircleCI test failed? The package exist and can local build success.

[javache]

I have some changes up for review internally that remove MessageQueueThreadRegistry completely (D5111966), let's land that first and rebase your change on that.

[yk3372]

ok, Thanks

[javache]

That has landed as 275ba31 Can you please rebase?