Fix configure glog script when building from xcodebuild

[janicduplessis]

I encountered an issue when building with fastlane gym / xcodebuild where glog would not build because of missing config.h header file. I tracked it down to the ios-configure-glog.sh script that ended up error-ing because of missing valid c compiler. I guess it didn't enter the if to set c compiler env in xcodebuild and that env doesn't have proper values set like it does in xcode so just removing this check fixed it. Also tested that it still works properly in xcode.

[janicduplessis]

cc @javache

[javache]

I added this because it was causing issues with the tvos build (see the Travis failure here). Maybe a better approach would be to get the right -sdk iphoneos flag from the environment?

[janicduplessis]

@javache I see, I think getting -sdk flag from the env is the right solution I'll figure out how to get that.

[janicduplessis]

@javache Ok I've figured the problem we need to get both the sdk and the arch from the build env variables (tvos is arm64 probably why it didn't work).

Tested that it builds for simulator and archive on iOS and tvOS.

[javache]

Awesome! Maybe we should provide defaults for these variables as well? In case people end up running the script outside of Xcode.

[janicduplessis]

@javache Added default values that match what the old code did

[facebook-github-bot]

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[rborn]

@janicduplessis I still have this issue. I have some pods installed and fastlane gym will complain with the below error while an xcode build (from the workspace of course) will go smooth

Any ideas? 😊

Undefined symbols for architecture arm64:
  "facebook::react::parseTypeFromHeader(facebook::react::BundleHeader const&)", referenced from:
      +[RCTJavaScriptLoader attemptSynchronousLoadOfBundleAtURL:runtimeBCVersion:sourceLength:error:] in libReact.a(RCTJavaScriptLoader.o)
  "_JSNoBytecodeFileFormatVersion", referenced from:
      +[RCTJavaScriptLoader loadBundleAtURL:onProgress:onComplete:] in libReact.a(RCTJavaScriptLoader.o)
      +[RCTJavaScriptLoader attemptSynchronousLoadOfBundleAtURL:runtimeBCVersion:sourceLength:error:] in libReact.a(RCTJavaScriptLoader.o)
ld: symbol(s) not found for architecture arm64