Add DeltaBundler's Flow types to flow config #20953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@empyrical merged commit d283d8f into Once this commit is added to a release, you will see the corresponding version tag below the description at d283d8f. If the commit has a single |
gengjiawen
pushed a commit
to gengjiawen/react-native
that referenced
this pull request
Sep 14, 2018
Summary:
This PR adds a declaration to `flow-github/metro.js` that fixes this error in `ci/circleci: analyze`:
```
Error ----------------------------------------------------- node_modules/metro-config/src/configTypes.flow.js.flow:18:27
Cannot resolve module `metro/src/DeltaBundler/types.flow.js`.
18| import type {Module} from 'metro/src/DeltaBundler/types.flow.js';
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
Pull Request resolved: facebook#20953
Differential Revision: D9642861
Pulled By: hramos
fbshipit-source-id: c73c546b1645a3df9bb5f541764135f8a0c76578
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary:
This PR adds a declaration to `flow-github/metro.js` that fixes this error in `ci/circleci: analyze`:
```
Error ----------------------------------------------------- node_modules/metro-config/src/configTypes.flow.js.flow:18:27
Cannot resolve module `metro/src/DeltaBundler/types.flow.js`.
18| import type {Module} from 'metro/src/DeltaBundler/types.flow.js';
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
Pull Request resolved: facebook#20953
Differential Revision: D9642861
Pulled By: hramos
fbshipit-source-id: c73c546b1645a3df9bb5f541764135f8a0c76578
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a declaration to
flow-github/metro.jsthat fixes this error inci/circleci: analyze:Test Plan:
This fixes an error that happens during
yarn flow check- it now passes.Release Notes:
[CLI] [BUGFIX] [flow-github/metro.js] - Added a flow type declaration for
metro/src/DeltaBundler/types.flow.js