SwipeableRow: Remove PropTypes, convert to ES6 class #21386
Conversation
facebook-github-bot
added
the
CLA Signed
|
|
||
| close(): void { | ||
| this.props.onClose(); | ||
| this.props.onClose && this.props.onClose(); |
There was a problem hiding this comment.
onClose is required based on the propTypes, you shouldn't need this check. If you do, then the flow types for onClose aren't properly showing that it is required.
|
|
||
| _handlePanResponderMove(event: PressEvent, gestureState: GestureState): void { | ||
| if (this._isSwipingExcessivelyRightFromClosedPosition(gestureState)) { | ||
| return; | ||
| } | ||
|
|
||
| this.props.onSwipeStart(); | ||
| this.props.onSwipeStart && this.props.onSwipeStart(); |
There was a problem hiding this comment.
If you could check the other ones in this file too that would be great.
|
Cleaned up those nullchecks, and removed the nullability of the other props that have default props |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@empyrical merged commit 16f06bc into Once this commit is added to a release, you will see the corresponding version tag below the description at 16f06bc. If the commit has a single |
hramos
removed
Import Started
Summary: Part of: facebook#21342 This PR removes prop types from `SwipeableRow`, and converts it from a `createReactClass` to an ES6 class. Pull Request resolved: facebook#21386 Differential Revision: D10100555 Pulled By: TheSavior fbshipit-source-id: ab350546f4fa6f1ed3fdeae07e342890af6d9a22
Part of: #21342
This PR removes prop types from
SwipeableRow, and converts it from acreateReactClassto an ES6 class.Test Plan:
flow checkpasses. Nothing seems off in Android RNTester.Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[GENERAL] [ENHANCEMENT] [Libraries/Experimental/SwipeableRow/SwipeableRow.js] - Removed PropTypes, converted to ES6 class