Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM] Add specs for AccessibilityInfo #24891

Closed
wants to merge 3 commits into from
Closed

[TM] Add specs for AccessibilityInfo #24891

wants to merge 3 commits into from

Conversation

michalchudziak
Copy link
Contributor

Summary

Part of #24875

Changelog

[General] [Added] - Add TurboModule spec for AccessibilityInfo

Test Plan

Run yarn flow on the root level

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2019
@michalchudziak michalchudziak added p: Callstack Partner: Callstack Partner labels May 16, 2019
@react-native-bot react-native-bot added API: AccessibilityInfo Type: Enhancement A new feature or enhancement of an existing feature. labels May 16, 2019
Copy link
Contributor

@RSNara RSNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 😁

However, before we land this PR, I have a few question/concerns that I'd like you to address.

@ericlewis ericlewis added the Flow label May 16, 2019
Copy link
Contributor

@RSNara RSNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @michalchudziak in 67c3ed3.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 22, 2019
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
Part of facebook#24875

## Changelog

[General] [Added] - Add TurboModule spec for AccessibilityInfo
Pull Request resolved: facebook#24891

Reviewed By: fkgozali

Differential Revision: D15394913

Pulled By: RSNara

fbshipit-source-id: e66e7b7fc4451575b5022695f125c15f9f4b707e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: AccessibilityInfo CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Flow Merged This PR has been merged. Native Module p: Callstack Partner: Callstack Partner Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants