Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade CLI to 2.0.0-rc.1 #25190

Closed
wants to merge 1 commit into from

Conversation

thymikee
Copy link
Contributor

@thymikee thymikee commented Jun 7, 2019

Summary

The RC1 of the CLI upgrades Metro to 0.54.1 to be compatible with 0.60 and master and fixes an issue with haste backwards compatibility.

cc @kelset

Changelog

[General] [Changed] - Bump CLI to 2.0.0-rc.1

Test Plan

🙈

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Jun 7, 2019
@pull-bot
Copy link

pull-bot commented Jun 7, 2019

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against dd01aad

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @thymikee in 782e848.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 10, 2019
@hramos
Copy link
Contributor

hramos commented Jun 11, 2019

Screen Shot 2019-06-11 at 3 23 18 PM

A couple of tests regressed once the changes from this PR landed in master. Where tests green when this PR was merged, or is there another commit I should be looking at?

M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
The RC1 of the CLI upgrades Metro to 0.54.1 to be compatible with 0.60 and master and fixes an issue with haste backwards compatibility.

cc kelset

## Changelog

[General] [Changed] - Bump CLI to 2.0.0-rc.1
Pull Request resolved: facebook#25190

Differential Revision: D15737249

Pulled By: cpojer

fbshipit-source-id: a39747620a7652507d29f5dadb6a4bdc9c1393f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants