Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] [Fix] - Install watchman in e2e tests to fix CI #25257

Closed
wants to merge 1 commit into from

Conversation

thymikee
Copy link
Contributor

@thymikee thymikee commented Jun 13, 2019

Summary

An attempt to fix CI.
This PR includes changes from #25241, to be removed once synced to master

Changelog

[Internal] [Fix] - Install watchman in e2e tests to fix CI

Test Plan

Happy CI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Jun 13, 2019
@pull-bot
Copy link

pull-bot commented Jun 13, 2019

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 1ebc879

@thymikee
Copy link
Contributor Author

E2E tests are fixed, yay! Now coveralls, looks like we hit this: lemurheavy/coveralls-public#632

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you take out the CLI changes from this PR again?

@thymikee
Copy link
Contributor Author

@cpojer yap! Just force-pushed that

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@thymikee thymikee changed the title WIP: install watchman in e2e tests Install watchman in e2e tests to fix CI Jun 13, 2019
@thymikee thymikee changed the title Install watchman in e2e tests to fix CI [Internal] [Fix] - Install watchman in e2e tests to fix CI Jun 13, 2019
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @thymikee in 488a91b.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 13, 2019
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
An attempt to fix CI.
This PR includes changes from facebook#25241, to be removed once synced to master

## Changelog

[General] [Fix] - install watchman in e2e tests to fix CI
Pull Request resolved: facebook#25257

Differential Revision: D15804513

Pulled By: cpojer

fbshipit-source-id: 33d4494ffaa340f99f1dae8764449e81e552c943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants