Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hermes binary path #25598

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Fix Hermes binary path #25598

merged 1 commit into from
Jul 11, 2019

Conversation

zoontek
Copy link
Contributor

@zoontek zoontek commented Jul 11, 2019

Summary

Hermes command targets a wrong binary path

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2019
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against cbe42d8

@kelset kelset requested a review from cpojer July 11, 2019 17:46
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpojer cpojer merged commit 348b8f0 into facebook:0.60-stable Jul 11, 2019
janicduplessis pushed a commit to janicduplessis/react-native that referenced this pull request Jul 12, 2019
janicduplessis pushed a commit to janicduplessis/react-native that referenced this pull request Jul 19, 2019
@zhuSass
Copy link

zhuSass commented Aug 26, 2019

This fix was not fixed in the latest version, at least in Windows 10:
A problem occurred starting process 'command '....\node_modules\hermesvm\win64-bin\hermes''

@YazeedAsaad
Copy link

This fix was not fixed in the latest version, at least in Windows 10:
A problem occurred starting process 'command '....\node_modules\hermesvm\win64-bin\hermes''

im still encountring this issue, did you find any workaround or should i just give up on hermes on windows

@bishwajeet-billme
Copy link

This fix was not fixed in the latest version, at least in Windows 10:
A problem occurred starting process 'command '....\node_modules\hermesvm\win64-bin\hermes''

I am also facing same problem did you find any suitable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants