Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SoLoader to 0.8.0 #26759

Closed
wants to merge 2 commits into from
Closed

Conversation

Alaa-Ben
Copy link

@Alaa-Ben Alaa-Ben commented Oct 8, 2019

Summary

This PR bumps bumps Soloader to 0.8.0. This fixes white screen/ crash issues when downloading from Google Play.

Related to:
#25927 #26400

Changelog

[Android] [Changed] - Bump Soloader to 0.8.0

Test Plan

A few CI tests fail, but I don't see the link with what I changed, especially the ios tests.
It's working locally though, and for people on github who tried this solution as well.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@pull-bot
Copy link

pull-bot commented Oct 8, 2019

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 3f2b1b1

@react-native-bot react-native-bot added the Platform: Android Android applications. label Oct 8, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Alaa-Ben Alaa-Ben marked this pull request as ready for review October 8, 2019 09:29
@Alaa-Ben Alaa-Ben changed the title feature(SoLoader) Bumped SoLoader to 0.8.0 Bumped SoLoader to 0.8.0 Oct 8, 2019
@Alaa-Ben Alaa-Ben changed the title Bumped SoLoader to 0.8.0 Bump SoLoader to 0.8.0 Oct 8, 2019
@radko93
Copy link
Contributor

radko93 commented Oct 8, 2019

Tested this in my apps and it did no harm and fixed linked issues.

Copy link
Contributor

@dulmandakh dulmandakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

diegolmello added a commit to RocketChat/Rocket.Chat.ReactNative that referenced this pull request Oct 8, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mdvacca
Copy link
Contributor

mdvacca commented Oct 9, 2019

LGTM, CC @ejanzer

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Alaa Ben El Ahmar in 6140398.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 9, 2019
grabbou pushed a commit that referenced this pull request Oct 11, 2019
Summary:
This PR bumps bumps Soloader to 0.8.0. This fixes white screen/ crash issues when downloading from Google Play.

Related to:
#25927 #26400

## Changelog
[Android] [Changed] - Bump Soloader to 0.8.0
Pull Request resolved: #26759

Test Plan:
A few CI tests fail, but I don't see the link with what I changed, especially the ios tests.
It's working locally though, and for people on github who tried this solution as well.

Differential Revision: D17828891

Pulled By: mdvacca

fbshipit-source-id: 1c7809aa681b41b8ed9a4da96d041d52f3cfbb76
grabbou added a commit that referenced this pull request Oct 28, 2019
raghav-mylagary added a commit to raghav-mylagary/mattermost-mobile that referenced this pull request Nov 10, 2019
@ScreamZ
Copy link

ScreamZ commented Nov 16, 2019

Is that available on some RN released version bad surprise in production for me…

douglowder pushed a commit to react-native-tvos/react-native-tvos that referenced this pull request Dec 11, 2019
Summary:
This PR bumps bumps Soloader to 0.8.0. This fixes white screen/ crash issues when downloading from Google Play.

Related to:
facebook/react-native#25927 #26400

## Changelog
[Android] [Changed] - Bump Soloader to 0.8.0
Pull Request resolved: facebook/react-native#26759

Test Plan:
A few CI tests fail, but I don't see the link with what I changed, especially the ios tests.
It's working locally though, and for people on github who tried this solution as well.

Differential Revision: D17828891

Pulled By: mdvacca

fbshipit-source-id: 1c7809aa681b41b8ed9a4da96d041d52f3cfbb76
@vidsag
Copy link

vidsag commented Jan 4, 2021

Hi.. I am currently using RN 0.61.4. I am trying to upgrade to latest SoLoader to fix some ANR is loadLibrary. Then I saw an upgrade to SoLoader was reverted for 0.61.4. Any reason as to why this was reverted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants