Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Update the cached dimensions when orientation changes #30324

Closed
wants to merge 1 commit into from
Closed

[Android] Update the cached dimensions when orientation changes #30324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,9 @@ public void onGlobalLayout() {
return;
}
checkForKeyboardEvents();
checkForDeviceOrientationChanges();
if (checkForDeviceOrientationChanges()) {
DisplayMetricsHolder.initDisplayMetrics(getContext().getApplicationContext());
}
checkForDeviceDimensionsChanges();
}

Expand Down Expand Up @@ -747,16 +749,17 @@ private void checkForKeyboardEvents() {
}
}

private void checkForDeviceOrientationChanges() {
private boolean checkForDeviceOrientationChanges() {
final int rotation =
((WindowManager) getContext().getSystemService(Context.WINDOW_SERVICE))
.getDefaultDisplay()
.getRotation();
if (mDeviceRotation == rotation) {
return;
return false;
ajpaulingalls marked this conversation as resolved.
Show resolved Hide resolved
}
mDeviceRotation = rotation;
emitOrientationChanged(rotation);
return true;
}

private void checkForDeviceDimensionsChanges() {
Expand Down