Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Native Module codegen into Xcode build pipeline #30449

Closed
wants to merge 1 commit into from

Commits on Dec 2, 2020

  1. Integrate Native Module codegen into Xcode build pipeline (facebook#3…

    …0449)
    
    Summary:
    Move the codegen invocation out of Podfiles and into the FBReactNativeSpec Pod itself. With this change, developers do not need to modify their existing project's Podfiles, and yet the codegen will be integrated into their projects automatically by way of the FBReactNativeSpec Pod.
    
    This is accomplished in part by injecting a script build phase into the Pods Xcode project that is generated by CocoaPods. The build phase will save the output of the codegen script to a log in the derived files directory. The codegen will be executed if the codegen log file is not present, or if the contents of the Libraries directory has changed.
    
    The codegen will thus be invoked in these situations:
    
    **RNTester:**
    * When `packages/rn-tester/RNTesterPods.xcworkspace` is built, if the codegen output logfile is not present or if the input files have changed.
    
    **OSS React Native apps:**
    * When `ios/AwesomeProject.xcworkspace` is built, if the codegen output file is not present or if the input files have changed. Normally, this should not happen, as we do not expect folks to update the contents of `node_modules/react-native/Libraries`.
    
    Pull Request resolved: facebook#30449
    
    Changelog: [Internal] - Moved codegen invocation out of Podfile and into FBReactNativeSpec Pod
    
    Reviewed By: fkgozali
    
    Differential Revision: D25138896
    
    fbshipit-source-id: 6c6738664fc3ea87642530e2b4d3ec4d946b3545
    hramos authored and facebook-github-bot committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    377b444 View commit details
    Browse the repository at this point in the history