-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental VirtualList Optimization (#27115) #31947
Conversation
Summary: This is VirtualList Optimization done by christianbach in facebook#21163 enabled behind a prop: `experimentalVirtualizedListOpt` with backward compatibility. Fixes facebook#20174 based of jasekiw pull request facebook#20208 ## Changelog // TODO: [CATEGORY] [TYPE] - Message Pull Request resolved: facebook#27115 Test Plan: // TODO: Add tests related to backward compatibility. (Will need help) Differential Revision: D30095387 Pulled By: lunaleaps fbshipit-source-id: 1c41e9e52beeb79b56b19dfb12d896a2c4c49529
This pull request was exported from Phabricator. Differential Revision: D30095387 |
|
Base commit: 8a8a532 |
Ah, I see. I love this approach. 😍 Less Nesting, Less Props. Just that now in the same tree, you can't have two versions of VirtualList one with optimization and one without. (Which I am totally fine with) |
In case you are interested, take a look at #31327 as well. I hope it is relevant. Thanks. |
Mm that's a good point. I think since this is a question of optimizing overall that's a fine tradeoff. We'll want to run an experiment internally.. to be honest I'm not sure I understand the optimization... might have to scan the issue history a bit more closely or if you could give me TL;DR? I'll re-post this on the original PR and we can continue discussion there. |
Summary:
This is VirtualList Optimization done by christianbach in #21163 enabled behind a prop:
experimentalVirtualizedListOpt
with backward compatibility.Fixes #20174 based of jasekiw pull request #20208
Changelog
// TODO:
[CATEGORY] [TYPE] - Message
Pull Request resolved: #27115
Test Plan:
// TODO:
Add tests related to backward compatibility. (Will need help)
Differential Revision: D30095387
Pulled By: lunaleaps