Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental VirtualList Optimization (#27115) #31947

Closed
wants to merge 1 commit into from

Conversation

lunaleaps
Copy link
Contributor

Summary:
This is VirtualList Optimization done by christianbach in #21163 enabled behind a prop: experimentalVirtualizedListOpt with backward compatibility.

Fixes #20174 based of jasekiw pull request #20208

Changelog

// TODO:

[CATEGORY] [TYPE] - Message

Pull Request resolved: #27115

Test Plan:
// TODO:
Add tests related to backward compatibility. (Will need help)

Differential Revision: D30095387

Pulled By: lunaleaps

Summary:
This is VirtualList Optimization done by christianbach in facebook#21163 enabled behind a prop: `experimentalVirtualizedListOpt` with backward compatibility.

Fixes facebook#20174 based of jasekiw pull request facebook#20208

## Changelog

// TODO:

[CATEGORY] [TYPE] - Message

Pull Request resolved: facebook#27115

Test Plan:
// TODO:
Add tests related to backward compatibility. (Will need help)

Differential Revision: D30095387

Pulled By: lunaleaps

fbshipit-source-id: 1c41e9e52beeb79b56b19dfb12d896a2c4c49529
@facebook-github-bot facebook-github-bot added p: Facebook Partner: Facebook Partner CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Aug 4, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30095387

@pull-bot
Copy link

pull-bot commented Aug 4, 2021

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against bd4bdfc

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 8a8a532

@azizhk
Copy link

azizhk commented Aug 4, 2021

Ah, I see. I love this approach. 😍 Less Nesting, Less Props.

Just that now in the same tree, you can't have two versions of VirtualList one with optimization and one without. (Which I am totally fine with)

@halaei
Copy link
Contributor

halaei commented Aug 4, 2021

In case you are interested, take a look at #31327 as well. I hope it is relevant. Thanks.

@lunaleaps
Copy link
Contributor Author

lunaleaps commented Aug 4, 2021

Ah, I see. I love this approach. 😍 Less Nesting, Less Props.

Just that now in the same tree, you can't have two versions of VirtualList one with optimization and one without. (Which I am totally fine with)

Mm that's a good point. I think since this is a question of optimizing overall that's a fine tradeoff. We'll want to run an experiment internally.. to be honest I'm not sure I understand the optimization... might have to scan the issue history a bit more closely or if you could give me TL;DR?

I'll re-post this on the original PR and we can continue discussion there.

@lunaleaps lunaleaps closed this Aug 5, 2021
@lunaleaps lunaleaps deleted the export-D30095387 branch August 5, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VirtualizedList- inefficient function passing for CellRenderer
6 participants