Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fix for app freeze issue when modal closes #32450

Closed
wants to merge 4 commits into from
Closed

Added fix for app freeze issue when modal closes #32450

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7808b8e
Added fix for app freeze issue when modal closes
Oct 21, 2021
b9b1718
Added the required to explicitly mention self, in dismissModalViewCon…
Oct 25, 2021
9cb99ea
Merge branch 'facebook:main' into ios/modal-dismissal
hurali97 Nov 5, 2021
233404a
_isPresented moved inside callback for the dispatch_async
hurali97 Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions React/Views/RCTModalHostView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,12 @@ - (void)didUpdateReactSubviews

- (void)dismissModalViewController
{
if (_isPresented) {
[_delegate dismissModalHostView:self withViewController:_modalViewController animated:[self hasAnimationType]];
_isPresented = NO;
}
dispatch_async(dispatch_get_main_queue(), ^{
if (_isPresented) {
[self->_delegate dismissModalHostView:self withViewController:self->_modalViewController animated:[self hasAnimationType]];
self->_isPresented = NO;
}
});
}

- (void)didMoveToWindow
Expand Down