Move cocoapods utilities to utils.rb - Part 1 #33978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37004347 |
Base commit: a0e6ffe |
Base commit: a0e6ffe |
Summary: Pull Request resolved: facebook#33978 This Diff moves part of the utilities from the `react_native_pods` file to a specific `utils.rb` file. It adds tests for these utils and improve our test mocks. The goal is to simplify the `react_native_pods.rb` so it's easier to work with it. I decided to split this diff in 2 because it was becoming quite big. ## Changelog [iOS][Changed] - Refactoring part of the react_native_pods.rb script Reviewed By: cortinico Differential Revision: D37004347 fbshipit-source-id: 0cb55d2555168b203d520265545851325ec8bbcd
|
This pull request was exported from Phabricator. Differential Revision: D37004347 |
cipolleschi
force-pushed
the
export-D37004347
branch
from
bb6da12
to
0599639
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 9, 2022
Summary: Pull Request resolved: facebook#33978 This Diff moves part of the utilities from the `react_native_pods` file to a specific `utils.rb` file. It adds tests for these utils and improve our test mocks. The goal is to simplify the `react_native_pods.rb` so it's easier to work with it. I decided to split this diff in 2 because it was becoming quite big. ## Changelog [iOS][Changed] - Refactoring part of the react_native_pods.rb script Differential Revision: D37004347 fbshipit-source-id: ecc1b1cb0825440e9e5ae5a92846bc8fe8602d99
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 9, 2022
Summary: Pull Request resolved: facebook#33978 This Diff moves part of the utilities from the `react_native_pods` file to a specific `utils.rb` file. It adds tests for these utils and improve our test mocks. The goal is to simplify the `react_native_pods.rb` so it's easier to work with it. I decided to split this diff in 2 because it was becoming quite big. ## Changelog [iOS][Changed] - Refactoring part of the react_native_pods.rb script Differential Revision: D37004347 fbshipit-source-id: 22e87b28ebe034e068eb0d5eba22212b6faed6c3
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 10, 2022
Summary: Pull Request resolved: facebook#33978 This Diff moves part of the utilities from the `react_native_pods` file to a specific `utils.rb` file. It adds tests for these utils and improve our test mocks. The goal is to simplify the `react_native_pods.rb` so it's easier to work with it. I decided to split this diff in 2 because it was becoming quite big. ## Changelog [iOS][Changed] - Refactoring part of the react_native_pods.rb script Differential Revision: https://www.internalfb.com/diff/D37004347?entry_point=27 fbshipit-source-id: d56d6b940948951a66f8d60ae584be99491248f1
|
This pull request was successfully merged by @cipolleschi in 7a27044. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff moves part of the utilities from the
react_native_podsfile to a specificutils.rbfile.It adds tests for these utils and improve our test mocks.
The goal is to simplify the
react_native_pods.rbso it's easier to work with it.I decided to split this diff in 2 because it was becoming quite big.
Differential Revision: D37004347
Changelog
[iOS][Changed] - Refactoring part of the react_native_pods.rb script