Move TypeScript declarations into react-native #34614

lunaleaps · 2022-09-06T18:18:26Z

Summary

Release TypesScript types with react-native and eventually deprecate @types/react-native.

The current plan is to release @types/react-native for 0.70 and 0.71 while also maintaining types here. This will result in some double maintenance until 0.72 but will give community time to move off of @types/react-native.

After this lands, there have been changes on main of types that we need to update. Then, when we release 0.71 from DefinitelyTyped, we can simply copy over the types folder from this repo.

Changelog

[General] [Added] - Add types folder to house TypeScript types.

Test Plan

yarn run test-typescript for linting types

Created a new project using the TS template and my local clone of react-native on this branch.
npx react-native init MyTSApp --version <path-to-my-local-rn-repo> --template react-native-template-typescript
Updated the package.json to remove @types/react-native
Deleted my node_modules and re-ran yarn
Opened MyTSApp in VSCode and verified the type suggestions appeared and cmd+click to defnitions took me to the node_module dependency react-native/types

Danger is failing on this PR and it's expected

as it runs off the changes on main. This is expected. However testing it locally passes

$ react-native/packages/react-native-bots
❯ yarn danger pr https://github.com/facebook/react-native/pull/34614
yarn run v1.22.19
$ ..react-native/node_modules/.bin/danger pr https://github.com/facebook/react-native/pull/34614
Starting Danger PR on facebook/react-native#34614

Danger: ✓ found only warnings, not failing the build
## Warnings
:lock: package.json - <i>Changes were made to package.json. This will require a manual import by a Facebook employee.</i>

✨  Done in 13.24s.

github-actions · 2022-09-06T18:19:39Z

	Fails
🚫	`node` failed.

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Log

Error:  Error: Failed to load parser '@typescript-eslint/parser' declared in '../../.eslintrc.js » @react-native-community/eslint-config#overrides[1]': Cannot find module 'typescript'
Require stack:
- /home/runner/work/react-native/react-native/node_modules/@typescript-eslint/typescript-estree/dist/parser.js
- /home/runner/work/react-native/react-native/node_modules/@typescript-eslint/typescript-estree/dist/index.js
- /home/runner/work/react-native/react-native/node_modules/@typescript-eslint/parser/dist/parser.js
- /home/runner/work/react-native/react-native/node_modules/@typescript-eslint/parser/dist/index.js
- /home/runner/work/react-native/react-native/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:956:15)
    at Function.Module._load (node:internal/modules/cjs/loader:804:27)
    at Function._module2.default._load (/home/runner/work/react-native/react-native/node_modules/override-require/dist/overrideRequire.js:43:25)
    at Module.require (node:internal/modules/cjs/loader:1028:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/runner/work/react-native/react-native/node_modules/@typescript-eslint/typescript-estree/dist/parser.js:35:25)
    at Module._compile (node:internal/modules/cjs/loader:1126:14)
    at Object.customModuleHandler (/home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:129:28)
    at Module.load (node:internal/modules/cjs/loader:1004:32)
    at Function.Module._load (node:internal/modules/cjs/loader:839:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/react-native/react-native/node_modules/@typescript-eslint/typescript-estree/dist/parser.js',
    '/home/runner/work/react-native/react-native/node_modules/@typescript-eslint/typescript-estree/dist/index.js',
    '/home/runner/work/react-native/react-native/node_modules/@typescript-eslint/parser/dist/parser.js',
    '/home/runner/work/react-native/react-native/node_modules/@typescript-eslint/parser/dist/index.js',
    '/home/runner/work/react-native/react-native/node_modules/@eslint/eslintrc/dist/eslintrc.cjs'
  ]
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against fbcba62

analysis-bot · 2022-09-06T18:44:37Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,694,713	+0
android	hermes	armeabi-v7a	7,098,120	+0
android	hermes	x86	7,997,323	+0
android	hermes	x86_64	7,969,796	+0
android	jsc	arm64-v8a	9,565,094	+0
android	jsc	armeabi-v7a	8,332,078	+0
android	jsc	x86	9,505,525	+0
android	jsc	x86_64	10,097,156	+0

Base commit: d15a82d
Branch: main

analysis-bot · 2022-09-06T19:39:30Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: d15a82d
Branch: main

lunaleaps · 2022-09-06T21:50:29Z

.eslintignore

@@ -9,3 +9,4 @@ Libraries/vendor/**/*
 node_modules/
 packages/*/node_modules
 packages/react-native-codegen/lib
+types/**/*


I'm not sure if I should be doing this.

lunaleaps · 2022-09-08T17:25:44Z

Currently trying to figure out why Danger eslint fails.

NickGerleman · 2022-09-08T20:17:49Z

.eslintrc.js

+      parser: '@typescript-eslint/parser',
+      plugins: ['@typescript-eslint/eslint-plugin'],
+      rules: {
+        '@typescript-eslint/no-unused-vars': 0,


nit: ESLint maps 0, 1, 2 to "off", "warn", "error". So using "off" instead of 0 might be more readable.

NickGerleman · 2022-09-08T20:24:55Z

packages/eslint-config-react-native-community/package.json

@@ -23,7 +23,8 @@
    "eslint-plugin-prettier": "^4.2.1",
    "eslint-plugin-react": "^7.30.1",
    "eslint-plugin-react-hooks": "^4.6.0",
-    "eslint-plugin-react-native": "^4.0.0"
+    "eslint-plugin-react-native": "^4.0.0",
+    "typescript": "^4.8.2"


This package is used externally as well, but the .eslintrc which adds TS usage is internal to the repo. It would be ideal if the dependency is only added in the internal config.

Otherwise if used in the community ESLint config, it should maybe be a peerDependency with a loose constraint like eslint/prettier, so the app can control the version.

Yes, I originally had it under repo-config/package.json but have this as currently trying to debug why danger isn't working. This didn't end up helping so will update this!

NickGerleman · 2022-09-08T20:36:23Z

types/tslint.json

@@ -0,0 +1,23 @@
+{
+    "extends": "@definitelytyped/dtslint/dtslint.json", 
+    "rules": {


In case you haven't stumbled onto it yet, a lot of these have direct mappings to ESLint rules documented at https://typescript-eslint.io/rules/.

Oh nice! Thank you! I had not found that! I can get rid of this then!

Hmm so I think a lot of the tslint rules we have here are custom for TS declarations and don't have a eslint equivalent. In that case, we'd still need to run dtslint and extend @definitelytyped/dtslint/dtslint.json (which defines some of the rules we're disabling here). So I think any additions to eslint would be un-necessary

lunaleaps · 2022-09-10T06:41:21Z

Added fixes to our danger setup to #34652. Once that lands, and we rebase this, then danger should stop failing.

Summary: When working on facebook#34614, danger is failing because it doesn't share `node_modules` with the root directory where `typescript` is installed as we added it as a parser in our eslint config. By setting `bots` as a yarn workspace, dependencies are all installed under the root `node_modules` folder and in local testing (detailed in test section) we no longer have the `typescript module not found` error. However, danger will continue to fail on facebook#34614 as the `danger_pr` Github action runs from what's defined on `main`. Once these changes land, I can rebase facebook#34614 on it and danger's eslint should pass. ## Changelog  [Internal][Fixed] - Add `bots` directory as a yarn workspace and update `danger_pr` Github action Pull Request resolved: facebook#34652 Test Plan: To verify this fix I had to run: ``` react-native $ yarn && cd bots react-native/bots$ yarn run danger pr facebook#34614 ``` which resulted in ``` ❯ yarn run danger pr facebook#34614 yarn run v1.22.19 $ lunaleaps/react-native/node_modules/.bin/danger pr facebook#34614 Starting Danger PR on facebook#34614 Danger: ✓ found only warnings, not failing the build ## Warnings :lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee. ✨ Done in 12.78s. ``` Verified this also on another PR: ``` yarn run danger pr facebook#34650 ``` Reviewed By: NickGerleman Differential Revision: D39435286 Pulled By: lunaleaps fbshipit-source-id: b560d92635be8d95baf27274f745315aaf56d748

Summary: allow-large-files When working on #34614, danger is failing because it doesn't share `node_modules` with the root directory where `typescript` is installed as we added it as a parser in our eslint config. By setting `bots` as a yarn workspace, dependencies are all installed under the root `node_modules` folder and in local testing (detailed in test section) we no longer have the `typescript module not found` error. However, danger will continue to fail on #34614 as the `danger_pr` Github action runs from what's defined on `main`. Once these changes land, I can rebase #34614 on it and danger's eslint should pass. ## Changelog  [Internal][Fixed] - Add `bots` directory as a yarn workspace and update `danger_pr` Github action Pull Request resolved: #34652 Test Plan: To verify this fix I had to run: ``` react-native $ yarn && cd bots react-native/bots$ yarn run danger pr #34614 ``` which resulted in ``` ❯ yarn run danger pr #34614 yarn run v1.22.19 $ lunaleaps/react-native/node_modules/.bin/danger pr #34614 Starting Danger PR on #34614 Danger: ✓ found only warnings, not failing the build ## Warnings :lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee. ✨ Done in 12.78s. ``` Verified this also on another PR: ``` yarn run danger pr #34650 ``` Reviewed By: NickGerleman Differential Revision: D39435286 Pulled By: lunaleaps fbshipit-source-id: 8c82f49facf162f4fc0918e3abd95eb7e4ad1e37

Libraries/LogBox/Data/__tests__/parseLogBoxLog-test.js

facebook-github-bot · 2022-09-13T19:46:13Z

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2022-09-14T00:38:19Z

This pull request was exported from Phabricator. Differential Revision: D39479137

Summary: ## Changelog [General] [Added] - Add `types` folder to house TypeScript types. Release TypesScript types with react-native and eventually deprecate [types/react-native](https://www.npmjs.com/package/types/react-native). The current plan is to release types/react-native for 0.70 and 0.71 while also maintaining types here. This will result in some double maintenance until 0.72 but will give community time to move off of types/react-native. After this lands, there have been changes on `main` of types that we need to update. Then, when we release 0.71 from DefinitelyTyped, we can simply copy over the `types` folder from this repo. Pull Request resolved: facebook#34614 Test Plan: `yarn run test-typescript` for linting types * Created a new project using the TS template and my local clone of `react-native` on this branch. `npx react-native init MyTSApp --version <path-to-my-local-rn-repo> --template react-native-template-typescript` * Updated the `package.json` to remove `types/react-native` * Deleted my node_modules and re-ran yarn * Opened MyTSApp in VSCode and verified the type suggestions appeared and cmd+click to defnitions took me to the node_module dependency `react-native/types` ## Danger is failing on this PR and it's expected as it runs off the changes on `main`. [This is expected](https://docs.github.com/en/github-ae@latest/actions/using-workflows/events-that-trigger-workflows?fbclid=IwAR2_AE0Jwndt8Gu-iTQnxGxLJq7nakbi7sz8jwZ6U62JWLSdcZuvjcQ6WvE#pull_request_target). However testing it locally passes ``` $ react-native/packages/react-native-bots ❯ yarn danger pr facebook#34614 yarn run v1.22.19 $ ..react-native/node_modules/.bin/danger pr facebook#34614 Starting Danger PR on facebook#34614 Danger: ✓ found only warnings, not failing the build ## Warnings :lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee. ✨ Done in 13.24s. ``` Differential Revision: D39479137 Pulled By: lunaleaps fbshipit-source-id: 3e2202b0436e7cb75101b042be916d3ba211d9f5

acoates-ms · 2022-09-14T16:33:31Z

package.json

@@ -93,7 +94,8 @@
    "test-android-instrumentation": "yarn run docker-build-android && yarn run test-android-run-instrumentation",
    "test-android-unit": "yarn run docker-build-android && yarn run test-android-run-unit",
    "test-android-e2e": "yarn run docker-build-android && yarn run test-android-run-e2e",
-    "test-ios": "./scripts/objc-test.sh test"
+    "test-ios": "./scripts/objc-test.sh test",
+    "test-typescript": "dtslint types"


Is anything running these tests during build/pr?

Not yet, will address this!

I've added running dtslint as part of the analyze_code CircleCI tests

facebook-github-bot · 2022-09-14T17:54:37Z

This pull request was exported from Phabricator. Differential Revision: D39479137

Summary: ## Changelog [General] [Added] - Add `types` folder to house TypeScript types. Release TypesScript types with react-native and eventually deprecate [types/react-native](https://www.npmjs.com/package/types/react-native). The current plan is to release types/react-native for 0.70 and 0.71 while also maintaining types here. This will result in some double maintenance until 0.72 but will give community time to move off of types/react-native. After this lands, there have been changes on `main` of types that we need to update. Then, when we release 0.71 from DefinitelyTyped, we can simply copy over the `types` folder from this repo. Pull Request resolved: facebook#34614 Test Plan: `yarn run test-typescript` for linting types * Created a new project using the TS template and my local clone of `react-native` on this branch. `npx react-native init MyTSApp --version <path-to-my-local-rn-repo> --template react-native-template-typescript` * Updated the `package.json` to remove `types/react-native` * Deleted my node_modules and re-ran yarn * Opened MyTSApp in VSCode and verified the type suggestions appeared and cmd+click to defnitions took me to the node_module dependency `react-native/types` ## Danger is failing on this PR and it's expected as it runs off the changes on `main`. [This is expected](https://docs.github.com/en/github-ae@latest/actions/using-workflows/events-that-trigger-workflows?fbclid=IwAR2_AE0Jwndt8Gu-iTQnxGxLJq7nakbi7sz8jwZ6U62JWLSdcZuvjcQ6WvE#pull_request_target). However testing it locally passes ``` $ react-native/packages/react-native-bots ❯ yarn danger pr facebook#34614 yarn run v1.22.19 $ ..react-native/node_modules/.bin/danger pr facebook#34614 Starting Danger PR on facebook#34614 Danger: ✓ found only warnings, not failing the build ## Warnings :lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee. ✨ Done in 13.24s. ``` Differential Revision: D39479137 Pulled By: lunaleaps fbshipit-source-id: 2883124712c756f731fe1bbb45e3629480296d82

Summary: ## Changelog [General] [Added] - Add `types` folder to house TypeScript types. Release TypesScript types with react-native and eventually deprecate [types/react-native](https://www.npmjs.com/package/types/react-native). The current plan is to release types/react-native for 0.70 and 0.71 while also maintaining types here. This will result in some double maintenance until 0.72 but will give community time to move off of types/react-native. After this lands, there have been changes on `main` of types that we need to update. Then, when we release 0.71 from DefinitelyTyped, we can simply copy over the `types` folder from this repo. Pull Request resolved: facebook#34614 Test Plan: `yarn run test-typescript` for linting types * Created a new project using the TS template and my local clone of `react-native` on this branch. `npx react-native init MyTSApp --version <path-to-my-local-rn-repo> --template react-native-template-typescript` * Updated the `package.json` to remove `types/react-native` * Deleted my node_modules and re-ran yarn * Opened MyTSApp in VSCode and verified the type suggestions appeared and cmd+click to defnitions took me to the node_module dependency `react-native/types` ## Danger is failing on this PR and it's expected as it runs off the changes on `main`. [This is expected](https://docs.github.com/en/github-ae@latest/actions/using-workflows/events-that-trigger-workflows?fbclid=IwAR2_AE0Jwndt8Gu-iTQnxGxLJq7nakbi7sz8jwZ6U62JWLSdcZuvjcQ6WvE#pull_request_target). However testing it locally passes. Once merged, and these changes are on `main`, danger will pass again. ``` $ react-native/packages/react-native-bots ❯ yarn danger pr facebook#34614 yarn run v1.22.19 $ ..react-native/node_modules/.bin/danger pr facebook#34614 Starting Danger PR on facebook#34614 Danger: ✓ found only warnings, not failing the build ## Warnings :lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee. ✨ Done in 13.24s. ``` Reviewed By: mdvacca Differential Revision: D39479137 Pulled By: lunaleaps fbshipit-source-id: a7398492386abee9543b3bb5d98682cdf15f54da

facebook-github-bot · 2022-09-17T03:15:03Z

This pull request was exported from Phabricator. Differential Revision: D39479137

react-native-bot · 2022-09-19T19:30:05Z

This pull request was successfully merged by @lunaleaps in 6b2a511.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: From changes in #34614, I forgot to actually export the types directory. ## Changelog  [Internal] - Add types directory as part of the npm package Pull Request resolved: #34727 Test Plan: Verified on [`build_npm_package_1`](https://app.circleci.com/pipelines/github/facebook/react-native/15799/workflows/4fd57bfc-0142-49d9-a1a6-83fa43f0e371/jobs/295438) job where we create the commitly, that `types` folder is included and `__typetests__` are ignored Reviewed By: cipolleschi Differential Revision: D39646310 Pulled By: lunaleaps fbshipit-source-id: 361f7925fa1cdc30d0865d291933c7fce9e0fa49

SimenB · 2022-09-21T07:22:49Z

package.json

@@ -93,7 +94,8 @@
    "test-android-instrumentation": "yarn run docker-build-android && yarn run test-android-run-instrumentation",
    "test-android-unit": "yarn run docker-build-android && yarn run test-android-run-unit",
    "test-android-e2e": "yarn run docker-build-android && yarn run test-android-run-e2e",
-    "test-ios": "./scripts/objc-test.sh test"
+    "test-ios": "./scripts/objc-test.sh test",
+    "test-typescript": "dtslint types"


I don't know if you explored this, but there is https://github.com/jest-community/jest-runner-tsd allowing you to run type tests with Jest instead of adding a new tool.

You might have ported tests from DT, in which case using the same tool is easier, I guess 😀

Also, super excited you've done this! 🎉

Summary: allow-large-files When working on facebook#34614, danger is failing because it doesn't share `node_modules` with the root directory where `typescript` is installed as we added it as a parser in our eslint config. By setting `bots` as a yarn workspace, dependencies are all installed under the root `node_modules` folder and in local testing (detailed in test section) we no longer have the `typescript module not found` error. However, danger will continue to fail on facebook#34614 as the `danger_pr` Github action runs from what's defined on `main`. Once these changes land, I can rebase facebook#34614 on it and danger's eslint should pass. ## Changelog  [Internal][Fixed] - Add `bots` directory as a yarn workspace and update `danger_pr` Github action Pull Request resolved: facebook#34652 Test Plan: To verify this fix I had to run: ``` react-native $ yarn && cd bots react-native/bots$ yarn run danger pr facebook#34614 ``` which resulted in ``` ❯ yarn run danger pr facebook#34614 yarn run v1.22.19 $ lunaleaps/react-native/node_modules/.bin/danger pr facebook#34614 Starting Danger PR on facebook#34614 Danger: ✓ found only warnings, not failing the build ## Warnings :lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee. ✨ Done in 12.78s. ``` Verified this also on another PR: ``` yarn run danger pr facebook#34650 ``` Reviewed By: NickGerleman Differential Revision: D39435286 Pulled By: lunaleaps fbshipit-source-id: 8c82f49facf162f4fc0918e3abd95eb7e4ad1e37

Summary: ## Changelog [General] [Added] - Add `types` folder to house TypeScript types. Release TypesScript types with react-native and eventually deprecate [types/react-native](https://www.npmjs.com/package/types/react-native). The current plan is to release types/react-native for 0.70 and 0.71 while also maintaining types here. This will result in some double maintenance until 0.72 but will give community time to move off of types/react-native. After this lands, there have been changes on `main` of types that we need to update. Then, when we release 0.71 from DefinitelyTyped, we can simply copy over the `types` folder from this repo. Pull Request resolved: facebook#34614 Test Plan: `yarn run test-typescript` for linting types * Created a new project using the TS template and my local clone of `react-native` on this branch. `npx react-native init MyTSApp --version <path-to-my-local-rn-repo> --template react-native-template-typescript` * Updated the `package.json` to remove `types/react-native` * Deleted my node_modules and re-ran yarn * Opened MyTSApp in VSCode and verified the type suggestions appeared and cmd+click to defnitions took me to the node_module dependency `react-native/types` ## Danger is failing on this PR and it's expected as it runs off the changes on `main`. [This is expected](https://docs.github.com/en/github-ae@latest/actions/using-workflows/events-that-trigger-workflows?fbclid=IwAR2_AE0Jwndt8Gu-iTQnxGxLJq7nakbi7sz8jwZ6U62JWLSdcZuvjcQ6WvE#pull_request_target). However testing it locally passes. Once merged, and these changes are on `main`, danger will pass again. ``` $ react-native/packages/react-native-bots ❯ yarn danger pr facebook#34614 yarn run v1.22.19 $ ..react-native/node_modules/.bin/danger pr facebook#34614 Starting Danger PR on facebook#34614 Danger: ✓ found only warnings, not failing the build ## Warnings :lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee. ✨ Done in 13.24s. ``` Reviewed By: mdvacca Differential Revision: D39479137 Pulled By: lunaleaps fbshipit-source-id: 1d506f812d566b783b6e79104cd6339b077a42a7

Summary: From changes in facebook#34614, I forgot to actually export the types directory. ## Changelog  [Internal] - Add types directory as part of the npm package Pull Request resolved: facebook#34727 Test Plan: Verified on [`build_npm_package_1`](https://app.circleci.com/pipelines/github/facebook/react-native/15799/workflows/4fd57bfc-0142-49d9-a1a6-83fa43f0e371/jobs/295438) job where we create the commitly, that `types` folder is included and `__typetests__` are ignored Reviewed By: cipolleschi Differential Revision: D39646310 Pulled By: lunaleaps fbshipit-source-id: 361f7925fa1cdc30d0865d291933c7fce9e0fa49

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 6, 2022

lunaleaps commented Sep 6, 2022

View reviewed changes

react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 7, 2022

lunaleaps changed the title ~~WIP to move things over~~ [WIP] Move TS declarations into react-native Sep 7, 2022

lunaleaps force-pushed the add-typescript branch from 7361226 to 885e8a3 Compare September 7, 2022 22:40

NickGerleman reviewed Sep 8, 2022

View reviewed changes

lunaleaps force-pushed the add-typescript branch from f7c71f2 to bd026bb Compare September 10, 2022 00:41

lunaleaps mentioned this pull request Sep 10, 2022

Add bots as a yarn workspace and update danger action #34652

Closed

lunaleaps force-pushed the add-typescript branch 2 times, most recently from 3b92183 to 5720242 Compare September 13, 2022 06:47

lunaleaps changed the title ~~[WIP] Move TS declarations into react-native~~ Move TS declarations into react-native Sep 13, 2022

lunaleaps force-pushed the add-typescript branch from 5720242 to 19ca785 Compare September 13, 2022 19:27

lunaleaps marked this pull request as ready for review September 13, 2022 19:38

lunaleaps requested a review from hramos as a code owner September 13, 2022 19:38

lunaleaps commented Sep 13, 2022

View reviewed changes

Libraries/LogBox/Data/__tests__/parseLogBoxLog-test.js Outdated Show resolved Hide resolved

lunaleaps changed the title ~~Move TS declarations into react-native~~ Move TypeScript declarations into react-native Sep 13, 2022

lunaleaps force-pushed the add-typescript branch from 19ca785 to 3f7439d Compare September 14, 2022 00:38

kelset added the Typescript label Sep 14, 2022

acoates-ms reviewed Sep 14, 2022

View reviewed changes

lunaleaps force-pushed the add-typescript branch from 3f7439d to d25a676 Compare September 14, 2022 17:54

lunaleaps force-pushed the add-typescript branch from d25a676 to fbcba62 Compare September 17, 2022 03:15

facebook-github-bot closed this in 6b2a511 Sep 19, 2022

react-native-bot added the Merged This PR has been merged. label Sep 19, 2022

lunaleaps deleted the add-typescript branch September 19, 2022 20:13

lunaleaps mentioned this pull request Sep 19, 2022

Fix: Publish types folder #34727

Closed

SimenB reviewed Sep 21, 2022

View reviewed changes

tido64 mentioned this pull request Sep 22, 2022

dep-check: Show warning for react-native 0.70x when @types/react-native was found as dependency microsoft/rnx-kit#1899

Closed

rahulnainwal107 mentioned this pull request Oct 5, 2022

ViewPropTypes has been removed from React Native... #34865

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move TypeScript declarations into react-native #34614

Move TypeScript declarations into react-native #34614

lunaleaps commented Sep 6, 2022 •

edited

Loading

github-actions bot commented Sep 6, 2022 •

edited

Loading

analysis-bot commented Sep 6, 2022 •

edited

Loading

analysis-bot commented Sep 6, 2022 •

edited

Loading

lunaleaps Sep 6, 2022

lunaleaps commented Sep 8, 2022

NickGerleman Sep 8, 2022

NickGerleman Sep 8, 2022

lunaleaps Sep 8, 2022

NickGerleman Sep 8, 2022

lunaleaps Sep 8, 2022

lunaleaps Sep 10, 2022

lunaleaps commented Sep 10, 2022

facebook-github-bot commented Sep 13, 2022

facebook-github-bot commented Sep 14, 2022

acoates-ms Sep 14, 2022

lunaleaps Sep 14, 2022

lunaleaps Sep 14, 2022

facebook-github-bot commented Sep 14, 2022

facebook-github-bot commented Sep 17, 2022

react-native-bot commented Sep 19, 2022

SimenB Sep 21, 2022

Move TypeScript declarations into react-native #34614

Move TypeScript declarations into react-native #34614

Conversation

lunaleaps commented Sep 6, 2022 • edited Loading

Summary

Changelog

Test Plan

Danger is failing on this PR and it's expected

github-actions bot commented Sep 6, 2022 • edited Loading

Log

analysis-bot commented Sep 6, 2022 • edited Loading

analysis-bot commented Sep 6, 2022 • edited Loading

Choose a reason for hiding this comment

lunaleaps commented Sep 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lunaleaps commented Sep 10, 2022

facebook-github-bot commented Sep 13, 2022

facebook-github-bot commented Sep 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Sep 14, 2022

facebook-github-bot commented Sep 17, 2022

react-native-bot commented Sep 19, 2022

Choose a reason for hiding this comment

lunaleaps commented Sep 6, 2022 •

edited

Loading

github-actions bot commented Sep 6, 2022 •

edited

Loading

analysis-bot commented Sep 6, 2022 •

edited

Loading

analysis-bot commented Sep 6, 2022 •

edited

Loading