Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CircleCI caches for hermesc be version dependent #37452

Closed
wants to merge 1 commit into from
Closed

Make CircleCI caches for hermesc be version dependent #37452

wants to merge 1 commit into from

Commits on May 23, 2023

  1. Make CircleCI caches for hermesc be version dependent (facebook#37452) 

    Summary:
Pull Request resolved: facebook#37452

Fixes facebook#37428

We do have cache poisoning for hermesc on Windows and Linux due to reusing the same cache key among different
React Native version. This fixes it by specifying a cache key which is version dependent + it invalidates the
caches by defining a new key.

Changelog:
[Internal] [Fixed] - Make CircleCI caches for hermesc be version dependent

Reviewed By: cortinico

Differential Revision: D45909178

fbshipit-source-id: 6a2fd88a49528a1b0357a62bb81eb9be08391122
    @cipolleschi @facebook-github-bot
    cipolleschi authored and facebook-github-bot committed May 23, 2023
    Configuration menu
    Copy the full SHA
    75a8bbe View commit details
    Browse the repository at this point in the history