Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codegen 129] add emitObjectProp in parser primitives #37904

Closed
wants to merge 1 commit into from

Conversation

tarunrajput
Copy link
Contributor

Summary:

This is a follow up PR to #37872 as it was not merged correctly.

Changelog:

[Internal][Changed]: Add emitObjectProp in parser primitives

Test Plan:

yarn test react-native-codegen

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2023
@rshest
Copy link
Contributor

rshest commented Jun 15, 2023

as it was not merged correctly

What exactly was the problem, could you provide more context?

@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tarunrajput
Copy link
Contributor Author

What exactly was the problem, could you provide more context?

@rshest, After you imported the PR internally, I pushed some changes to address CI issues. However, these changes were not merged as it seems the PR needs to be re-imported.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,757,683 +0
android hermes armeabi-v7a 8,070,258 +1
android hermes x86 9,250,279 -1
android hermes x86_64 9,099,417 +0
android jsc arm64-v8a 9,318,829 +1
android jsc armeabi-v7a 8,508,736 -1
android jsc x86 9,382,320 +1
android jsc x86_64 9,635,566 +0

Base commit: 894b62c
Branch: main

@rshest
Copy link
Contributor

rshest commented Jun 15, 2023

What exactly was the problem, could you provide more context?

@rshest, After you imported the PR internally, I pushed some changes to address CI issues. However, these changes were not merged as it seems the PR needs to be re-imported.

Ah, I see. Sorry for that!

Thanks for making it right.

@Pranav-yadav Pranav-yadav added the Tech: Codegen Related to react-native-codegen label Jun 15, 2023
@github-actions
Copy link

This pull request was successfully merged by @tarunrajput in 24f7707.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Jun 15, 2023
adamaveray added a commit to adamaveray/react-native that referenced this pull request Jun 16, 2023
* main: (135 commits)
  translation auto-update for i18n/twilight.config.json on master
  Interop: Introduce Bridge proxy
  Remove okhttp internal util usage (facebook#37843)
  Update debian to fix CI while updating Node (facebook#37841)
  fix: foreground ripple crash on api < 23 (facebook#37901)
  Re-add the top level LICENSE file (facebook#37916)
  Deploy 0.209.0 to xplat (facebook#37921)
  Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914)
  add emitObjectProp in parser primitives (facebook#37904)
  Make React-utils its own pod (facebook#37659)
  feat: allow custom assignment of rootView to rootViewController (facebook#37873)
  Switch xplat prettier config to hermes plugin (facebook#37915)
  Set iOS AppState to inactive when app is launching (facebook#37690)
  Use `fileExists` in replace_hermes script (facebook#37911)
  (docs): fix license url (facebook#37909)
  Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+
  Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874)
  Fix component type references in xplat (facebook#37903)
  Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867)
  test runtime lifecycle callback (facebook#37897)
  ...
@tarunrajput tarunrajput deleted the add-emitObjectProp branch June 27, 2023 11:12
@tarunrajput tarunrajput restored the add-emitObjectProp branch June 27, 2023 11:12
@tarunrajput tarunrajput deleted the add-emitObjectProp branch June 27, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Tech: Codegen Related to react-native-codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants