-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Codegen 129] add emitObjectProp in parser primitives #37904
Conversation
aee40b3
to
0cc8ad8
Compare
What exactly was the problem, could you provide more context? |
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@rshest, After you imported the PR internally, I pushed some changes to address CI issues. However, these changes were not merged as it seems the PR needs to be re-imported. |
Base commit: 894b62c |
Ah, I see. Sorry for that! Thanks for making it right. |
This pull request was successfully merged by @tarunrajput in 24f7707. When will my fix make it into a release? | Upcoming Releases |
* main: (135 commits) translation auto-update for i18n/twilight.config.json on master Interop: Introduce Bridge proxy Remove okhttp internal util usage (facebook#37843) Update debian to fix CI while updating Node (facebook#37841) fix: foreground ripple crash on api < 23 (facebook#37901) Re-add the top level LICENSE file (facebook#37916) Deploy 0.209.0 to xplat (facebook#37921) Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914) add emitObjectProp in parser primitives (facebook#37904) Make React-utils its own pod (facebook#37659) feat: allow custom assignment of rootView to rootViewController (facebook#37873) Switch xplat prettier config to hermes plugin (facebook#37915) Set iOS AppState to inactive when app is launching (facebook#37690) Use `fileExists` in replace_hermes script (facebook#37911) (docs): fix license url (facebook#37909) Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+ Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874) Fix component type references in xplat (facebook#37903) Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867) test runtime lifecycle callback (facebook#37897) ...
Summary:
This is a follow up PR to #37872 as it was not merged correctly.
Changelog:
[Internal][Changed]: Add emitObjectProp in parser primitives
Test Plan:
yarn test react-native-codegen