Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create RuntimeExecutor on non-JSI executors #38125

Closed
wants to merge 1 commit into from
Closed

Do not create RuntimeExecutor on non-JSI executors #38125

wants to merge 1 commit into from

Commits on Jun 30, 2023

  1. Do not create RuntimeExecutor on non-JSI executors (facebook#38125) 

    Summary:
Pull Request resolved: facebook#38125

On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`.

Changelog: [General][Fixed] Android does't crash when using remote debugger

Reviewed By: NickGerleman

Differential Revision: D47124234

fbshipit-source-id: d6e93c760174361940d53fe8c2ebf4685d8cf8ae
    @javache @facebook-github-bot
    javache authored and facebook-github-bot committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    a34c48f View commit details
    Browse the repository at this point in the history