fix: repairs $EXTRA_COMPILER_ARGS error with multiple args

[fergusean]

Summary:

Fixes a regression added on merge of #37531 (though oddly I don't see it in #37531's diff, so perhaps added during conflict resolution?) where multiple arguments in $EXTRA_COMPILER_ARGS are now incorrectly wrapped in quotes, including RN's own sourcemap support:

runner@SeansMacBookGo sampleapp % /Users/runner/builds/y_x6gsp4/0/sampleapp/ios/Pods/hermes-engine/destroot/bin/hermesc -emit-binary -max-diagnostic-width=80 '-O -output-source-map' -out /Users/runner/builds/y_x6gsp4/0/sampleapp/ios/build/derived-data/Build/Intermediates.noindex/ArchiveIntermediates/sampleapp/BuildProductsPath/Release-iphoneos/sampleapp.app/main.jsbundle /Users/runner/builds/y_x6gsp4/0/sampleapp/ios/build/derived-data/Build/Intermediates.noindex/ArchiveIntermediates/sampleapp/BuildProductsPath/Release-iphoneos/main.jsbundle
hermesc: Unknown command line argument '-O -output-source-map'.  Try: '/Users/runner/builds/y_x6gsp4/0/sampleapp/ios/Pods/hermes-engine/destroot/bin/hermesc -help'
hermesc: Did you mean '-output-source-map'?

Changelog:

[IOS] [FIXED] - Fix build error when there are multiple EXTRA_COMPILER_ARGS

Test Plan:

Removing the quotes and running the command results a successful run of hermesc (exit code 0 and the expected files produced).

[facebook-github-bot]

Hi @fergusean!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	9,047,338	-3
android	hermes	armeabi-v7a	8,296,755	+0
android	hermes	x86	9,563,637	-2
android	hermes	x86_64	9,405,789	-3
android	jsc	arm64-v8a	9,606,059	-2
android	jsc	armeabi-v7a	8,732,778	-3
android	jsc	x86	9,693,094	-3
android	jsc	x86_64	9,939,391	-1

Base commit: a9bfd7b
Branch: main

[louiszawadzki]

I have noticed the same issue as well, I cannot generate sourcemaps on iOS with RN 0.72.

I've applied the changes described here with the following test plan to further test this fix and can attest that it works:

1. Create a new RN project using npx react-native@latest init SourcemapsDemoApp
2. Add export SOURCEMAP_FILE=./main.jsbundle.map to the end of the ios/.xcode.env file
3. Open the project on XCode with xed ios
4. Change the XCode Scheme to set "Release" as build configuration
5. Build the project
6. The build fails
7. Edit node_modules/react-native/scripts/react-native-xcode.sh with the content from this PR
8. The build succeeds
9. Remove the line from ios/.xcode.env and rebuild
10. The build succeeds again

[cipolleschi]

Thanks for noticing. It was a mistake on my side. I'm going to have this landed.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[github-actions]

This pull request was successfully merged by @fergusean in 28f4eba.

^{When will my fix make it into a release? | Upcoming Releases}

[facebook-github-bot]

@cipolleschi merged this pull request in 28f4eba.