Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android platform border color (#39893) #41030

Closed
wants to merge 1 commit into from

Commits on Oct 17, 2023

  1. Fix android platform border color (facebook#39893)

    Summary:
    If you try to apply PlatformColor to borders on Android app will crash with the next error:
    
    "Error while updating property 'borderColor' of a view managed by: RCTView"
    
    ## Changelog:
    
    [ANDROID] [FIXED] - Fix android crash when apply PlatformColor to borders
    
    Pull Request resolved: facebook#39893
    
    Test Plan:
    In RNTester example, go to APIs -> PlatformColor
    |    Before  | After |
    | ----------- | ----------- |
    |  <img src="https://github.com/facebook/react-native/assets/70860930/66ac2880-53da-4438-bd9a-332f8ea40645" alt="drawing" width="200"/>    | <img src="https://github.com/facebook/react-native/assets/70860930/151f58a1-d857-4b3d-9ec6-de74eb065127" alt="drawing" width="200"/>      |
    
    Reviewed By: NickGerleman
    
    Differential Revision: D50011758
    
    Pulled By: javache
    
    fbshipit-source-id: ea06c18c6aef4b6731e9b9b87422a1e0d13de208
    (cherry picked from commit 265af22)
    axinvd authored and majkpal committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    61ebbda View commit details
    Browse the repository at this point in the history