Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][Local] Fix breaking changes in 0.74-rc.8 #44025

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Apr 10, 2024

Summary:

With #43757, we pushed some breaking changes in RC.8

This change makes those changes not breaking.

Note (for framework developers): if you keep the old version of the APIs - which are now marked as deprecated - some feature (for example DeepLinking) won't be working, because they rely on the new parameters that needs to be passed to RCTHost.

Changelog:

[iOS][Fixed] - Make the changes from #43757 not breaking

Test Plan:

Tested locally

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 10, 2024
@cipolleschi cipolleschi changed the base branch from main to 0.74-stable April 10, 2024 16:31
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-brreaking-change branch from 7b47ef5 to eb7c552 Compare April 10, 2024 16:38
@cipolleschi cipolleschi marked this pull request as ready for review April 10, 2024 16:38
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,820,459 -1,580,414
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,178,721 -1,597,461
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3f2b1d7
Branch: main

@cipolleschi
Copy link
Contributor Author

cipolleschi commented Apr 10, 2024

the failing gh action is okay. It is pulling hermes from main, but, of course, it can't work when the target branch is a stable one, which expect hermes from the stable version.

@cortinico
Copy link
Contributor

Closing as no longer necessary

@cortinico cortinico closed this Jun 10, 2024
@cortinico cortinico deleted the cipolleschi/fix-brreaking-change branch June 10, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants