chore: Increase iOS script portability #44417

legobeat · 2024-05-05T23:41:56Z

Summary:

pod install and CocoaPods are actually not macOS specific.
Still, the pod lifecycle scripts of react-native depend on macOS-only utilities and will fail on Linux.

This is an attempt to make the scripts portable and make the pod install cleanly on Linux as well as macOS.

Changelog:

[INTERNAL] [FIXED] - Skip XCode patching when not run on macOS
[INTERNAL] [FIXED] - Fall back to `which gcc`/`which g++` to identify C/C++ compiler when `xcrun` not available
[INTERNAL] [FEAT] - Recognize CC and CXX env vars supplied to the script and prefer them over autodetection

Test Plan:

analysis-bot · 2024-05-06T00:13:06Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	19,542,747	-6
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	22,912,806	-11
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 93c079b
Branch: main

NickGerleman · 2024-05-06T21:06:32Z

I kinda suspect this breaks a lot of other assumptions in the build logic. What is use-case and how far does this actually get?

legobeat · 2024-05-06T21:27:17Z

I kinda suspect this breaks a lot of other assumptions in the build logic. What is use-case and how far does this actually get?

I think the use-case can be summarized as "can run pod install for a project using react-native as dependency on Linux without error". This can be useful e.g. in CI jobs validating Podfile.lock consistency as well as for auditing and experimental development on Linux.

I believe this will retain existing behavior for any scenario that wasn't already erroring before this change.

(Separately, it does feel surprising even on macOS that installing this as a dependency would be automatically and silently be changing the user's Xcode project settings - but that's not the point here)

cipolleschi

Changes looks good to me.
I know that cocoapods can be used outside MacOS, but we never encountered the use case before.

facebook-github-bot · 2024-05-07T16:17:57Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

legobeat · 2024-05-14T22:51:53Z

Rebased on main; no changes.

legobeat · 2024-05-16T23:01:57Z

@cipolleschi Thanks!

Some small improvements, should be good to go now I believe. PR description updated.

cipolleschi · 2024-05-20T09:30:10Z

/rebase - this comment automatically rebase on top of main

cipolleschi · 2024-05-20T09:30:49Z

Sorry for the delay, I have been busy with the React Conf and couldn't really work on anything else. I'm rebasing automatically on top of main, given that many tests were red in CI.

… available

- fix: Don't attempt xcrun if not present - fix: Default to g++ instead of gcc for CXX when Xcode not present - feat: Allow user to override CC and CXX env vars

legobeat · 2024-05-20T09:37:45Z

Sorry for the delay, I have been busy with the React Conf and couldn't really work on anything else. I'm rebasing automatically on top of main, given that many tests were red in CI.

Thanks! I am surprised to see the errors show up. I just reverted the change which allows overriding the Xcode CC and CXX via env vars to see if that's what's causing it.

EDIT: Looks like that was it.

facebook-github-bot · 2024-05-20T12:40:03Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2024-05-20T13:44:02Z

@cipolleschi merged this pull request in 9970480.

github-actions · 2024-05-20T13:44:05Z

This pull request was successfully merged by @legobeat in 9970480.

^{When will my fix make it into a release? | How to file a pick request?}

- Enable `pod install` step in `yarn setup` script on all platforms - Failing installation is still only treated as actual failure on macOS - Apply `react-native` patch that resolves installation error due to attempt at patching missing Xcode - Upstream PR: facebook/react-native#44417 - Add developer `Dockerfile` which can be used locally to run routine development tasks like `yarn setup`. - Add CI job that builds docker image and tests it with metamask-mobile - In order for the new job to run, the newly used actions must be enabled in repository settings.

Summary: `pod install` and CocoaPods are actually not macOS specific. Still, the pod lifecycle scripts of `react-native` depend on macOS-only utilities and will fail on Linux. This is an attempt to make the scripts portable and make the pod install cleanly on Linux as well as macOS. ## Changelog: [INTERNAL] [FIXED] - Skip XCode patching when not run on macOS [INTERNAL] [FIXED] - Fall back to `which gcc`/`which g++` to identify C/C++ compiler when `xcrun` not available [INTERNAL] [FEAT] - Recognize CC and CXX env vars supplied to the script and prefer them over autodetection Pull Request resolved: #44417 Reviewed By: NickGerleman Differential Revision: D57055928 Pulled By: cipolleschi fbshipit-source-id: 1c49f70c52b4667abf0a215cbee52ee6aa6dd052

Summary: `pod install` and CocoaPods are actually not macOS specific. Still, the pod lifecycle scripts of `react-native` depend on macOS-only utilities and will fail on Linux. This is an attempt to make the scripts portable and make the pod install cleanly on Linux as well as macOS. ## Changelog: [INTERNAL] [FIXED] - Skip XCode patching when not run on macOS [INTERNAL] [FIXED] - Fall back to `which gcc`/`which g++` to identify C/C++ compiler when `xcrun` not available [INTERNAL] [FEAT] - Recognize CC and CXX env vars supplied to the script and prefer them over autodetection Pull Request resolved: facebook#44417 Reviewed By: NickGerleman Differential Revision: D57055928 Pulled By: cipolleschi fbshipit-source-id: 1c49f70c52b4667abf0a215cbee52ee6aa6dd052

…46358) Summary: Due to `set -e` shell option, missing `xcrun` may cause the setup script to fail on Linux. Also makes the script continue even if the glog `./configure` call does not succeed. ### Related - Follow-up to #44417 ## Changelog: - [Internal] [Fixed] - react-native: make missing xcrun not throw in `ios-configure-glog.sh` - [Internal] [Fixed] - react-native: accept failing glog ./configure in `ios-configure-glog.sh` Pull Request resolved: #46358 Reviewed By: cortinico Differential Revision: D62851737 Pulled By: cipolleschi fbshipit-source-id: 3ed76a81b6f428a1697c364698a0dfdd3bbb74f2

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2024

legobeat marked this pull request as ready for review May 6, 2024 00:14

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label May 6, 2024

legobeat mentioned this pull request May 6, 2024

chore: Fix CocoaPods install on Linux MetaMask/metamask-mobile#9545

Merged

7 tasks

cipolleschi approved these changes May 7, 2024

View reviewed changes

legobeat force-pushed the pods-outside-macos branch from 9a2400e to 5af62fc Compare May 14, 2024 22:51

legobeat force-pushed the pods-outside-macos branch from be345f5 to e8ec34c Compare May 16, 2024 23:05

legobeat added 3 commits May 20, 2024 09:31

fix: skip xcode 15 patch attempt in post-install when not on darwin

22a4f75

chore: fall back to which gcc to identify compiler when xcrun not…

0d535f0

… available

chore: fix and improve C/C++ compiler detection

791160a

- fix: Don't attempt xcrun if not present - fix: Default to g++ instead of gcc for CXX when Xcode not present - feat: Allow user to override CC and CXX env vars

github-actions bot force-pushed the pods-outside-macos branch from e8ec34c to 791160a Compare May 20, 2024 09:31

fix: don't allow user-overriding CC,CXX when runnning with Xcode

cee603b

fix: don't allow user-overriding CC,CXX when runnning with Xcode

a67eff7

facebook-github-bot closed this in 9970480 May 20, 2024

facebook-github-bot added the Merged This PR has been merged. label May 20, 2024

leotm mentioned this pull request May 29, 2024

[0.74] Increase iOS script portability reactwg/react-native-releases#296

Closed

legobeat mentioned this pull request May 30, 2024

chore(ci): lint Podfile.lock MetaMask/metamask-mobile#9789

Closed

7 tasks

This was referenced Jun 28, 2024

[CI] Move iOS Executors to M1 #45213

Closed

[Hermes] Bump Hermes #45220

Merged

cipolleschi mentioned this pull request Jul 22, 2024

[RN][0.74]Fix XROS build #45580

Merged

cipolleschi mentioned this pull request Jul 31, 2024

[RN][Hermes] Fore Hermes versions for slices through env var #45840

Merged

legobeat mentioned this pull request Sep 6, 2024

chore(react-native): accept failing glog configure in setup script #46358

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Increase iOS script portability #44417

chore: Increase iOS script portability #44417

legobeat commented May 5, 2024 •

edited

Loading

analysis-bot commented May 6, 2024 •

edited

Loading

NickGerleman commented May 6, 2024

legobeat commented May 6, 2024 •

edited

Loading

cipolleschi left a comment

facebook-github-bot commented May 7, 2024

legobeat commented May 14, 2024

legobeat commented May 16, 2024 •

edited

Loading

cipolleschi commented May 20, 2024

cipolleschi commented May 20, 2024

legobeat commented May 20, 2024 •

edited

Loading

facebook-github-bot commented May 20, 2024

facebook-github-bot commented May 20, 2024

github-actions bot commented May 20, 2024

chore: Increase iOS script portability #44417

chore: Increase iOS script portability #44417

Conversation

legobeat commented May 5, 2024 • edited Loading

Summary:

Changelog:

Test Plan:

analysis-bot commented May 6, 2024 • edited Loading

NickGerleman commented May 6, 2024

legobeat commented May 6, 2024 • edited Loading

cipolleschi left a comment

Choose a reason for hiding this comment

facebook-github-bot commented May 7, 2024

legobeat commented May 14, 2024

legobeat commented May 16, 2024 • edited Loading

cipolleschi commented May 20, 2024

cipolleschi commented May 20, 2024

legobeat commented May 20, 2024 • edited Loading

facebook-github-bot commented May 20, 2024

facebook-github-bot commented May 20, 2024

github-actions bot commented May 20, 2024

legobeat commented May 5, 2024 •

edited

Loading

analysis-bot commented May 6, 2024 •

edited

Loading

legobeat commented May 6, 2024 •

edited

Loading

legobeat commented May 16, 2024 •

edited

Loading

legobeat commented May 20, 2024 •

edited

Loading