[iOS] Fixes NSDataBigString length calculation #44900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
…/fix_js_data_length
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NickGerleman merged this pull request in 9d637e4. |
|
This pull request was successfully merged by @zhongwuzw in 9d637e4. When will my fix make it into a release? | How to file a pick request? |
realsoelynn
added a commit
to realsoelynn/react-native
that referenced
this pull request
Aug 14, 2024
Summary: Pull Request resolved: facebook#46011 Backing out D58561775 in the meantime while we are trying to do proper fix in Hermes engine D61058869 Changelog: [Internal] Temporarily revert this diff facebook#44900 while we wait for facebook#45966 to land Differential Revision: D61246120
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
Summary: Pull Request resolved: #46011 Backing out D58561775 in the meantime while we are trying to do proper fix in Hermes engine D61058869 Changelog: [Internal] Temporarily revert this diff #44900 while we wait for #45966 to land Reviewed By: makovkastar Differential Revision: D61246120 fbshipit-source-id: 8c205efe9d29cd34f24676c4a48d55f0493d73ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We assume data[length] is '\0', like Android
react-native/packages/react-native/ReactCommon/cxxreact/JSBigString.h
Line 81 in 33aa83a
ensureNullTerminated. it may crash in hermes engine because hermes should ensure data[length] is\0.Changelog:
[IOS] [FIXED] - Fixes NSDataBigString length calculation
Test Plan:
We can mimic the crash by changes some code :
