Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @react-native-community/cli direct dependencies #45927

Closed
wants to merge 1 commit into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Aug 7, 2024

Summary:
This was attempted earlier in the year, and was unsuccessful because HelloWorld had a hidden dependency on this.

Changelog: [General][Breaking] Projects that intend to use the community CLI will now have to declare that dependency instead of transitively having the react-native package handle this.

Differential Revision: D60898346

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 7, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60898346

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60898346

blakef added a commit to blakef/react-native that referenced this pull request Aug 8, 2024
Summary:
Pull Request resolved: facebook#45927

This was attempted earlier in the year, and was unsuccessful because HelloWorld had a hidden dependency on this.

Changelog: [General][Breaking] Projects that intend to use the community CLI will now have to declare that dependency instead of transitively having the react-native package handle this.

Differential Revision: D60898346
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60898346

blakef added a commit to blakef/react-native that referenced this pull request Aug 12, 2024
Summary:
Pull Request resolved: facebook#45927

This was attempted earlier in the year, and was unsuccessful because HelloWorld had a hidden dependency on this.

Changelog: [General][Breaking] Projects that intend to use the community CLI will now have to declare that dependency instead of transitively having the react-native package handle this.

Differential Revision: D60898346
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60898346

blakef added a commit to blakef/react-native that referenced this pull request Aug 12, 2024
Summary:
Pull Request resolved: facebook#45927

This was attempted earlier in the year, and was unsuccessful because HelloWorld had a hidden dependency on this.

Changelog: [General][Breaking] Projects that intend to use the community CLI will now have to declare that dependency instead of transitively having the react-native package handle this.

Differential Revision: D60898346
Summary:
Pull Request resolved: facebook#45927

This was attempted earlier in the year, and was unsuccessful because HelloWorld had a hidden dependency on this.

Changelog: [General][Breaking] Projects that intend to use the community CLI will now have to declare that dependency instead of transitively having the react-native package handle this.

Differential Revision: D60898346
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60898346

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in bd3a3e3.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 14, 2024
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @blakef in bd3a3e3

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants