Add support for assymetrical bonder radii when using % #45985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61025927 |
Summary: Pull Request resolved: facebook#45985 As title. We can now create ellipses when using percentages. The algorithm for this is still flawed and to get it to be a 1:1 to web it will probably require a re-write of some of the logic but this should get us closer for now. Some examples: 1. Border thinning on large single corner radii (100%) {F1798145800} 2. Thinning gets worse when having irregular border colors (100%) {F1798148002} Changelog: [Internal] Differential Revision: D61025927
|
This pull request was exported from Phabricator. Differential Revision: D61025927 |
jorge-cab
force-pushed
the
export-D61025927
branch
from
f3781ee
to
7850926
Compare
|
This pull request has been merged in d69dbd6. |
|
This pull request was successfully merged by @jorge-cab in d69dbd6 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title.
We can now create ellipses when using percentages. The algorithm for this is still flawed and to get it to be a 1:1 to web it will probably require a re-write of some of the logic but this should get us closer for now.
Some examples:
{F1798145800}
{F1798148002}
Changelog: [Internal]
Differential Revision: D61025927