[ANDROID] fontFamily, fontStyle and fontWeight support for TextInput #6564

brunobar79 · 2016-03-21T16:27:26Z

fontFamily, fontWeight and fontStyle properties are being ignored for TextInput.

There's an additional issue that happens when you add secureTextEntry={true} it overrides the current font preferences (because it defaults to monospace) so we have to reapply it.
Master right now:

Demo after the fix:

facebook-github-bot · 2016-03-21T16:28:10Z

By analyzing the blame information on this pull request, we identified @dmmiller, @mkonicek and @kmagiera to be potential reviewers.

dmmiller · 2016-03-21T16:34:50Z

Again, please update the TextExample to show this being used please.

…79/react-native into pr/android-password-font-family

facebook-github-bot · 2016-03-21T17:44:24Z

@brunobar79 updated the pull request.

…79/react-native into pr/android-password-font-family

facebook-github-bot · 2016-03-21T17:47:28Z

@brunobar79 updated the pull request.

facebook-github-bot · 2016-03-21T17:48:19Z

@brunobar79 updated the pull request.

brunobar79 · 2016-03-21T17:50:01Z

@dmmiller TextInputExample updated (see gif above). Also added support for fontWeight and fontStyle, which it's all related to TypeFace. If you think this is ok I'll do the same with the color PR

facebook-github-bot · 2016-03-21T17:56:24Z

@brunobar79 updated the pull request.

dmmiller · 2016-03-21T20:53:06Z

Now that 2a2ba4b has landed, can you rebase since I think this uses the same example and then we can try landing this one?

dmmiller · 2016-03-21T20:55:26Z

Do we not support font family/weight/style for normal text input? Or do we but because of the way secure entry works we need to do this additionally?

brunobar79 · 2016-03-21T21:57:57Z

@dmmiller You're right! There's no support for fontFamily, fontStyle or fontWeight on regular text inputs.
I just took out the secureTextEntry prop and it's not working on the latest master:

I'm gonna rename this PR and make it for TextInput in general, and I'll update the examples.

brunobar79 · 2016-04-28T18:16:01Z

@bestander I just found the issue and finally got it working on android 4.4.2.

It was crashing on view.getTypeface().getStyle() cause view.getTypeface() returns null when there's no fontFamily or style previously set on Android 4.

Here you can see it working on android 4 and 6 after my last commit.

bestander · 2016-04-28T18:22:50Z

ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java

+    }
+
+    Typeface currentTypeface = view.getTypeface();
+    if(currentTypeface == null){


nit: could you add spaces before and after () please

bestander · 2016-04-28T18:24:18Z

@brunobar79, great, thanks a lot.
Let's merge it then after the tests pass :)
Could you fix just a few nits style-wise please?

brunobar79 · 2016-04-28T18:28:41Z

@bestander it should be good now.

ghost · 2016-04-28T18:29:15Z

@brunobar79 updated the pull request.

bestander · 2016-04-28T19:20:22Z

Travis build fail can be ignored, infra

bestander · 2016-04-28T19:20:27Z

@facebook-github-bot shipit

ghost · 2016-04-28T19:27:13Z

Thanks for importing. If you are an FB employee go to Phabricator to review.

Summary: fontFamily, fontWeight and fontStyle properties are being ignored for TextInput. There's an additional issue that happens when you add secureTextEntry={true} it overrides the current font preferences (because it defaults to monospace) so we have to reapply it. Master right now: ![screen shot 2016-03-21 at 6 21 05 pm](https://cloud.githubusercontent.com/assets/1247834/13936110/c25ffea8-ef91-11e5-8d71-1b0a55184e24.png) Demo after the fix: ![5ux4bpjfwh](https://cloud.githubusercontent.com/assets/1247834/13935865/0f2ca8be-ef90-11e5-82c7-d5a2dd33b70e.gif) Closes facebook#6564 Differential Revision: D3081623 Pulled By: bestander fb-gh-sync-id: 329cac6755b5a0dd549e546768f39efa7b7f4daa fbshipit-source-id: 329cac6755b5a0dd549e546768f39efa7b7f4daa

Creemli · 2017-07-04T02:02:58Z

Custom fontfamily is not supported for placeholder text

harveyconnor · 2020-10-19T11:02:57Z

I'm getting this in RN 0.63.3

metalpapa · 2020-10-19T12:58:41Z

i have RN updated an i have this same issue

Eramirez06 · 2020-10-26T05:47:52Z

i'm getting this too

hoangnv98 · 2020-10-27T09:36:16Z

when i set SecureTextEntry={true} , fontFamily show different fontFamily i change

hemang-thakkar · 2020-10-28T12:32:15Z

I m seeing this issue too.

ahummel25 · 2020-11-12T00:52:52Z

Also getting this in RN 0.63.3. Please reopen this.

harveyconnor · 2020-11-12T05:17:05Z

Please re-open @shergin @hramos

carlosdaniiel07 · 2020-11-20T01:13:39Z

This solved for me (0.63.3):

#30123 (comment)

kindacoder · 2022-03-12T16:43:41Z

same issue 0.64.0

brunobar79 added 2 commits March 21, 2016 12:23

added support for fontFamily

8430f42

Merge branch 'master' into pr/android-password-font-family

deef2f8

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 21, 2016

brunobar79 changed the title ~~fontFamily support for TextInput secureTextEntry={true}~~ [ANDROID] fontFamily support for TextInput secureTextEntry={true} Mar 21, 2016

brunobar79 mentioned this pull request Mar 21, 2016

fontFamily and color support for TextInput secureTextEntry={true} #6540

Closed

brunobar79 added 2 commits March 21, 2016 13:42

add support for font style and font weight

69f17b9

Merge branch 'pr/android-password-font-family' of github.com:brunobar…

4d115ee

…79/react-native into pr/android-password-font-family

brunobar79 changed the title ~~[ANDROID] fontFamily support for TextInput secureTextEntry={true}~~ [ANDROID] fontFamily, fontStyle and fontWeight support for TextInput secureTextEntry={true} Mar 21, 2016

brunobar79 added 3 commits March 21, 2016 13:45

Merge branch 'master' into pr/android-password-font-family

d76b7e4

clean up

f65da5d

Merge branch 'pr/android-password-font-family' of github.com:brunobar…

668b3ce

…79/react-native into pr/android-password-font-family

undo

685f640

fix indentation

7d173bb

brunobar79 added 6 commits March 21, 2016 17:31

added support for fontFamily

392515d

add support for font style and font weight

ec62d48

clean up

3ef87d7

undo

2a986fa

fix indentation

dd5a6c0

updated example

11f8727

bestander reviewed Apr 28, 2016
View reviewed changes

nits fix

597ecb8

ghost added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Apr 28, 2016

ghost closed this in 41e89b4 Apr 28, 2016

brunobar79 mentioned this pull request May 17, 2016

[Android] [TextInput] Placeholder font doesn't match TextInput styling #4600

Closed

timomeara mentioned this pull request Oct 14, 2020

SecureTextEntry prop is not working in android with all the keyboard types. #30148

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ANDROID] fontFamily, fontStyle and fontWeight support for TextInput #6564

[ANDROID] fontFamily, fontStyle and fontWeight support for TextInput #6564

brunobar79 commented Mar 21, 2016

facebook-github-bot commented Mar 21, 2016

dmmiller commented Mar 21, 2016

facebook-github-bot commented Mar 21, 2016

facebook-github-bot commented Mar 21, 2016

facebook-github-bot commented Mar 21, 2016

brunobar79 commented Mar 21, 2016

facebook-github-bot commented Mar 21, 2016

dmmiller commented Mar 21, 2016

dmmiller commented Mar 21, 2016

brunobar79 commented Mar 21, 2016

brunobar79 commented Apr 28, 2016

bestander Apr 28, 2016

bestander commented Apr 28, 2016

brunobar79 commented Apr 28, 2016

ghost commented Apr 28, 2016

bestander commented Apr 28, 2016

bestander commented Apr 28, 2016

ghost commented Apr 28, 2016

Creemli commented Jul 4, 2017

harveyconnor commented Oct 19, 2020

metalpapa commented Oct 19, 2020 •

edited

Loading

Eramirez06 commented Oct 26, 2020

hoangnv98 commented Oct 27, 2020

hemang-thakkar commented Oct 28, 2020

ahummel25 commented Nov 12, 2020

harveyconnor commented Nov 12, 2020

carlosdaniiel07 commented Nov 20, 2020

kindacoder commented Mar 12, 2022

[ANDROID] fontFamily, fontStyle and fontWeight support for TextInput #6564

[ANDROID] fontFamily, fontStyle and fontWeight support for TextInput #6564

Conversation

brunobar79 commented Mar 21, 2016

facebook-github-bot commented Mar 21, 2016

dmmiller commented Mar 21, 2016

facebook-github-bot commented Mar 21, 2016

facebook-github-bot commented Mar 21, 2016

facebook-github-bot commented Mar 21, 2016

brunobar79 commented Mar 21, 2016

facebook-github-bot commented Mar 21, 2016

dmmiller commented Mar 21, 2016

dmmiller commented Mar 21, 2016

brunobar79 commented Mar 21, 2016

brunobar79 commented Apr 28, 2016

bestander Apr 28, 2016

Choose a reason for hiding this comment

bestander commented Apr 28, 2016

brunobar79 commented Apr 28, 2016

ghost commented Apr 28, 2016

bestander commented Apr 28, 2016

bestander commented Apr 28, 2016

ghost commented Apr 28, 2016

Creemli commented Jul 4, 2017

harveyconnor commented Oct 19, 2020

metalpapa commented Oct 19, 2020 • edited Loading

Eramirez06 commented Oct 26, 2020

hoangnv98 commented Oct 27, 2020

hemang-thakkar commented Oct 28, 2020

ahummel25 commented Nov 12, 2020

harveyconnor commented Nov 12, 2020

carlosdaniiel07 commented Nov 20, 2020

kindacoder commented Mar 12, 2022

metalpapa commented Oct 19, 2020 •

edited

Loading