Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gradle version and android gradle plugin version #9573

Closed
wants to merge 1 commit into from
Closed

Update gradle version and android gradle plugin version #9573

wants to merge 1 commit into from

Conversation

felipecsl
Copy link
Contributor

I wasn't able to run Android instrumentation tests locally from Android Studio without bumping the gradle plugin version and gradle version.
I know that Facebook is planning to move away from Gradle into BUCK only, but this is a pretty straightforward change that seemed to fix it for me.

@felipecsl felipecsl changed the title Update gradle version and gradle version Update gradle version and android gradle plugin version Aug 24, 2016
@ghost
Copy link

ghost commented Aug 24, 2016

By analyzing the blame information on this pull request, we identified @mkonicek and @bestander to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 24, 2016
@alexHlebnikov
Copy link

There is already Gradle 3.0 released. And it needs classpath 'com.android.tools.build:gradle:2.2.0-beta2'. And also it needs Android Studio 2.2 Beta 2.

@felipecsl
Copy link
Contributor Author

The Android gradle plugin doesn't support gradle 3 yet.
Also I don't think we want to depend on the beta version, so this seems
like the safest option.

On Wed, Aug 24, 2016, 22:08 Alexander Khlebnikov [email protected]
wrote:

There is already Gradle 3.0 released. And it needs classpath
'com.android.tools.build:gradle:2.2.0-beta2'. And also it needs Android
Studio 2.2 Beta 2.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9573 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALouMrIkvb8fJEYgaO7onS8wIXMF5vGks5qjSNegaJpZM4JscvR
.

@bestander
Copy link
Contributor

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. and removed GH Review: review-needed labels Aug 25, 2016
@ghost
Copy link

ghost commented Aug 25, 2016

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost closed this in 6bfabee Aug 25, 2016
@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2016
@felipemsantana felipemsantana mentioned this pull request Aug 28, 2016
Closed
ghost pushed a commit that referenced this pull request Sep 9, 2016
@felipemsantana
Update gradle wrapper binary and scripts
68848f8 
Summary:
I ran ```./gradlew wrapper``` to update the gradle wrapper binary and scripts.

This is related to #9573
Closes #9619

Reviewed By: kentaromiura

Differential Revision: D3828085

Pulled By: bestander

fbshipit-source-id: 3c155c80f0f4e09b277337c6767104267357d159
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felipecsl @alexHlebnikov @bestander