fix NativeAnimated event listener bug #9729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bugfix cleans up reference to value listener upon unsubscribing to native events ultimately preventing RCTEventEmitter from throwing a [listener count error](https://github.com/facebook/react-native/blob/v0.33.0-rc.0/React/Modules/RCTEventEmitter.m#L90).
ghost
added
GH Review: review-needed
CLA Signed
jmurzy
added a commit
to jmurzy/react-router-native
that referenced
this pull request
Sep 4, 2016
`Animated.setValue` via NativeAnimated for iOS is buggy and causes panResponders to fail Also See facebook/react-native#9729
ghost
added
the
CLA Signed
|
Thanks! @facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
ide
pushed a commit
that referenced
this pull request
Sep 6, 2016
Summary: This bugfix cleans up reference to value listener upon unsubscribing to native events ultimately preventing RCTEventEmitter from throwing a [listener count error](https://github.com/facebook/react-native/blob/v0.33.0-rc.0/React/Modules/RCTEventEmitter.m#L90): `Attempted to remove more RCTNativeAnimatedModule listeners than added` /cc janicduplessis sahrens 🍺 Closes #9729 Differential Revision: D3818241 Pulled By: sahrens fbshipit-source-id: e235e3f97534ef2a50df29877ce36d3b6095237e
justim
added a commit
to guidiance/react-router-native
that referenced
this pull request
Sep 28, 2017
Reason for disabling it is no longer true See: jmurzy@4742270 See: facebook/react-native#9729
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix cleans up reference to value listener upon unsubscribing to native events ultimately preventing RCTEventEmitter from throwing a listener count error:
Attempted to remove more RCTNativeAnimatedModule listeners than added/cc @janicduplessis @sahrens
🍺