Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests runner #975

Merged
merged 2 commits into from
Apr 22, 2015
Merged

Fix tests runner #975

merged 2 commits into from
Apr 22, 2015

Conversation

frantic
Copy link
Contributor

@frantic frantic commented Apr 22, 2015

The old script was missing set -e, so its return code was taken from rm packager.log which usually gives 0.

@frantic
Copy link
Contributor Author

frantic commented Apr 22, 2015

cc @sahrens @spicyj

sophiebits
sophiebits reviewed Apr 22, 2015
View reviewed changes
scripts/objc-test.sh

if [ $EXIT_CODE -ne 0 ];
then
WATCHMAN_LOGS=/usr/local/Cellar/watchman/3.1/var/run/watchman/$USER.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe * instead of 3.1?

@sophiebits
Copy link
Contributor

lgtm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2015
frantic added a commit that referenced this pull request Apr 22, 2015
@frantic
Merge pull request #975 from frantic/enable-tests
76e5439 
Fix tests runner
@frantic frantic merged commit 76e5439 into facebook:master Apr 22, 2015
@frantic frantic mentioned this pull request Apr 22, 2015
Closed
@frantic frantic deleted the enable-tests branch April 22, 2015 23:35
ayushjainrksh pushed a commit to MLH-Fellowship/react-native that referenced this pull request Jul 2, 2020
@hramos @cpojer
[CI] Migrate to Circle CI 2.1 (facebook#975)
f76f9c7
This was referenced Mar 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@ebarahona ebarahona mentioned this pull request Jun 20, 2023
Open
@bumplzz69 bumplzz69 mentioned this pull request Jun 20, 2023
Open
@joseroubert08 joseroubert08 mentioned this pull request Jun 21, 2023
Open
@enterstudio enterstudio mentioned this pull request Jun 21, 2023
Open
@caschomburg123 caschomburg123 mentioned this pull request Jun 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frantic @sophiebits @facebook-github-bot @reactjs-bot