Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node-haste] Fix typo in new ModuleCache args #9774

Closed
wants to merge 1 commit into from
Closed

[node-haste] Fix typo in new ModuleCache args #9774

wants to merge 1 commit into from

Conversation

aleclarson
Copy link
Contributor

👍

@ghost
Copy link

ghost commented Sep 6, 2016

By analyzing the blame information on this pull request, we identified @davidaurelio to be a potential reviewer.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 6, 2016
@ide
Copy link
Contributor

ide commented Sep 6, 2016

LGTM but will wait for tests to pass in case fixing this uncovers another bug.

@mkonicek
Copy link
Contributor

mkonicek commented Sep 8, 2016

Thanks!

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Sep 8, 2016
@ghost
Copy link

ghost commented Sep 8, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2016
@ghost ghost closed this in 29febb9 Sep 8, 2016
@aleclarson aleclarson deleted the typo_modulecache_args branch September 8, 2016 15:47
cpojer pushed a commit to facebook/metro that referenced this pull request Jan 26, 2017
@aleclarson
Fix typo in new ModuleCache args
3b36662 
Summary:
:+1:
Closes facebook/react-native#9774

Differential Revision: D3835002

Pulled By: mkonicek

fbshipit-source-id: a94f07a7f32fe709f0a7bed561f26d1d9c5ac377
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleclarson @ide @mkonicek @facebook-github-bot