Skip to content

Commit

Permalink
Update isConcurrent RTR option usage (#28546)
Browse files Browse the repository at this point in the history
Reverting some of #27804 which
renamed this option to stable. This PR just replaces internal usage to
make upcoming PRs cleaner.

Keeping isConcurrent unstable for the next major release in order to
enable a broader deprecation of RTR and be consistent with concurrent
rendering everywhere for next major.
(#28498)
- Next major will use concurrent root
- The old behavior (legacy root by default, concurrent root with
unstable option) will be preserved for React Native until new
architecture is fully shipped.
- Flag and legacy root usage can be removed after RN dependency is
unblocked without an additional breaking change

DiffTrain build for [3832730](3832730)
  • Loading branch information
jackpope committed Mar 18, 2024
1 parent d06d633 commit 0ef0a51
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 11 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8
38327309a4172a52cf94e8e264990bedafc1df6e
7 changes: 2 additions & 5 deletions compiled/facebook-www/ReactTestRenderer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -26055,7 +26055,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-www-classic-91cd5cc2";
var ReactVersion = "18.3.0-www-classic-2256e5ca";

// Might add PROFILE later.

Expand Down Expand Up @@ -26959,10 +26959,7 @@ if (__DEV__) {
createNodeMock = options.createNodeMock;
}

if (
options.unstable_isConcurrent === true ||
options.isConcurrent === true
) {
if (options.unstable_isConcurrent === true) {
isConcurrent = true;
}

Expand Down
7 changes: 2 additions & 5 deletions compiled/facebook-www/ReactTestRenderer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -26055,7 +26055,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-www-modern-d806e7dc";
var ReactVersion = "18.3.0-www-modern-e9ba68a0";

// Might add PROFILE later.

Expand Down Expand Up @@ -26959,10 +26959,7 @@ if (__DEV__) {
createNodeMock = options.createNodeMock;
}

if (
options.unstable_isConcurrent === true ||
options.isConcurrent === true
) {
if (options.unstable_isConcurrent === true) {
isConcurrent = true;
}

Expand Down

0 comments on commit 0ef0a51

Please sign in to comment.