Merge pull request #5193 from conorhastings/enqueue-callback-error

update enqueueCallback invariant to more specifically denote type of passed callback
facebook · Oct 16, 2015 · 0fc8f6a · 0fc8f6a
2 parents ed7ab7b + 20ec78d
commit 0fc8f6a
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/renderers/shared/reconciler/ReactUpdateQueue.js b/src/renderers/shared/reconciler/ReactUpdateQueue.js
@@ -109,8 +109,10 @@ var ReactUpdateQueue = {
     invariant(
       typeof callback === 'function',
       'enqueueCallback(...): You called `setProps`, `replaceProps`, ' +
-      '`setState`, `replaceState`, or `forceUpdate` with a callback that ' +
-      'isn\'t callable.'
+      '`setState`, `replaceState`, or `forceUpdate` with a callback of type ' +
+      '%s. A function is expected',
+      typeof callback === 'object' && Object.keys(callback).length && Object.keys(callback).length < 20 ?
+        typeof callback + ' (keys: ' + Object.keys(callback) + ')' : typeof callback
     );
     var internalInstance = getInternalInstanceReadyForUpdate(publicInstance);
 
@@ -139,8 +141,10 @@ var ReactUpdateQueue = {
     invariant(
       typeof callback === 'function',
       'enqueueCallback(...): You called `setProps`, `replaceProps`, ' +
-      '`setState`, `replaceState`, or `forceUpdate` with a callback that ' +
-      'isn\'t callable.'
+      '`setState`, `replaceState`, or `forceUpdate` with a callback of type ' +
+      '%s. A function is expected',
+      typeof callback === 'object' && Object.keys(callback).length && Object.keys(callback).length < 20 ?
+        typeof callback + ' (keys: ' + Object.keys(callback) + ')' : typeof callback
     );
     if (internalInstance._pendingCallbacks) {
       internalInstance._pendingCallbacks.push(callback);