Skip to content

Commit

Permalink
Cleanup unused unstable_startTransition, unstable_useTransition, unst…
Browse files Browse the repository at this point in the history
…able_useDeferredValue exports from fb packages (#27056)

## Summary

came across these TODOs – an internal grep indicated that remaining
callsites have been cleaned up, so these can now be removed.

## How did you test this change?

```
yarn flow dom-browser
yarn test
```

DiffTrain build for commit e91142d.
  • Loading branch information
noahlemen committed Jul 5, 2023
1 parent 9a8a80b commit 70b01d0
Show file tree
Hide file tree
Showing 7 changed files with 50 additions and 65 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23982,7 +23982,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-canary-7118f5dd7-20230705";
var ReactVersion = "18.3.0-canary-e91142dd6-20230705";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8630,7 +8630,7 @@ var devToolsConfig$jscomp$inline_1032 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-7118f5dd7-20230705",
version: "18.3.0-canary-e91142dd6-20230705",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1231 = {
Expand Down Expand Up @@ -8661,7 +8661,7 @@ var internals$jscomp$inline_1231 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-7118f5dd7-20230705"
reconcilerVersion: "18.3.0-canary-e91142dd6-20230705"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1232 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9056,7 +9056,7 @@ var devToolsConfig$jscomp$inline_1074 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-7118f5dd7-20230705",
version: "18.3.0-canary-e91142dd6-20230705",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1272 = {
Expand Down Expand Up @@ -9087,7 +9087,7 @@ var internals$jscomp$inline_1272 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-7118f5dd7-20230705"
reconcilerVersion: "18.3.0-canary-e91142dd6-20230705"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1273 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<85cf0b54e8f0b417c4ef6e8f35c5a677>>
* @generated SignedSource<<e07addc76261adf5c9844f571089b66c>>
*/

'use strict';
Expand All @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-canary-7118f5dd7-20230705";
var ReactVersion = "18.3.0-canary-e91142dd6-20230705";

// ATTENTION
// When adding new symbols to this file,
Expand Down Expand Up @@ -3928,11 +3928,8 @@ exports.unstable_TracingMarker = REACT_TRACING_MARKER_TYPE;
exports.unstable_act = act;
exports.unstable_getCacheForType = getCacheForType;
exports.unstable_getCacheSignal = getCacheSignal;
exports.unstable_startTransition = startTransition;
exports.unstable_useCacheRefresh = useCacheRefresh;
exports.unstable_useDeferredValue = useDeferredValue;
exports.unstable_useMemoCache = useMemoCache;
exports.unstable_useTransition = useTransition;
exports.use = use;
exports.useCallback = useCallback;
exports.useContext = useContext;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<53c40bb7dda9ed688253fda038bc98ac>>
* @generated SignedSource<<c874b3507aeda09a93133667e1fcecd7>>
*/

"use strict";
Expand Down Expand Up @@ -280,32 +280,17 @@ function createCacheRoot() {
function createCacheNode() {
return { s: 0, v: void 0, o: null, p: null };
}
var ReactCurrentDispatcher = { current: null };
function useTransition() {
return ReactCurrentDispatcher.current.useTransition();
}
function useDeferredValue(value) {
return ReactCurrentDispatcher.current.useDeferredValue(value);
}
var ReactCurrentBatchConfig = { transition: null },
var ReactCurrentDispatcher = { current: null },
ReactCurrentBatchConfig = { transition: null },
ReactSharedInternals = {
ReactCurrentDispatcher: ReactCurrentDispatcher,
ReactCurrentCache: ReactCurrentCache,
ReactCurrentBatchConfig: ReactCurrentBatchConfig,
ReactCurrentOwner: ReactCurrentOwner$1,
ContextRegistry: {}
},
ContextRegistry = ReactSharedInternals.ContextRegistry;
function startTransition(scope) {
var prevTransition = ReactCurrentBatchConfig.transition;
ReactCurrentBatchConfig.transition = {};
try {
scope();
} finally {
ReactCurrentBatchConfig.transition = prevTransition;
}
}
var ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
ContextRegistry = ReactSharedInternals.ContextRegistry,
ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
RESERVED_PROPS = { key: !0, ref: !0, __self: !0, __source: !0 };
function jsx$1(type, config, maybeKey) {
var propName,
Expand Down Expand Up @@ -537,7 +522,15 @@ exports.memo = function (type, compare) {
compare: void 0 === compare ? null : compare
};
};
exports.startTransition = startTransition;
exports.startTransition = function (scope) {
var prevTransition = ReactCurrentBatchConfig.transition;
ReactCurrentBatchConfig.transition = {};
try {
scope();
} finally {
ReactCurrentBatchConfig.transition = prevTransition;
}
};
exports.unstable_Cache = REACT_CACHE_TYPE;
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
Expand All @@ -564,15 +557,12 @@ exports.unstable_getCacheSignal = function () {
),
dispatcher.signal);
};
exports.unstable_startTransition = startTransition;
exports.unstable_useCacheRefresh = function () {
return ReactCurrentDispatcher.current.useCacheRefresh();
};
exports.unstable_useDeferredValue = useDeferredValue;
exports.unstable_useMemoCache = function (size) {
return ReactCurrentDispatcher.current.useMemoCache(size);
};
exports.unstable_useTransition = useTransition;
exports.use = function (usable) {
return ReactCurrentDispatcher.current.use(usable);
};
Expand All @@ -583,7 +573,9 @@ exports.useContext = function (Context) {
return ReactCurrentDispatcher.current.useContext(Context);
};
exports.useDebugValue = function () {};
exports.useDeferredValue = useDeferredValue;
exports.useDeferredValue = function (value) {
return ReactCurrentDispatcher.current.useDeferredValue(value);
};
exports.useEffect = function (create, deps) {
return ReactCurrentDispatcher.current.useEffect(create, deps);
};
Expand Down Expand Up @@ -622,5 +614,7 @@ exports.useSyncExternalStore = function (
getServerSnapshot
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-canary-7118f5dd7-20230705";
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-e91142dd6-20230705";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<23eeabb4d0c92eafb27fe3cdffcaf299>>
* @generated SignedSource<<70baf3b541539dca5899f9c542f152f7>>
*/


Expand Down Expand Up @@ -258,32 +258,17 @@ function createCacheRoot() {
function createCacheNode() {
return { s: 0, v: void 0, o: null, p: null };
}
var ReactCurrentDispatcher = { current: null };
function useTransition() {
return ReactCurrentDispatcher.current.useTransition();
}
function useDeferredValue(value) {
return ReactCurrentDispatcher.current.useDeferredValue(value);
}
var ReactCurrentBatchConfig = { transition: null },
var ReactCurrentDispatcher = { current: null },
ReactCurrentBatchConfig = { transition: null },
ReactSharedInternals = {
ReactCurrentDispatcher: ReactCurrentDispatcher,
ReactCurrentCache: ReactCurrentCache,
ReactCurrentBatchConfig: ReactCurrentBatchConfig,
ReactCurrentOwner: ReactCurrentOwner$1,
ContextRegistry: {}
},
ContextRegistry = ReactSharedInternals.ContextRegistry;
function startTransition(scope) {
var prevTransition = ReactCurrentBatchConfig.transition;
ReactCurrentBatchConfig.transition = {};
try {
scope();
} finally {
ReactCurrentBatchConfig.transition = prevTransition;
}
}
var ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
ContextRegistry = ReactSharedInternals.ContextRegistry,
ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
RESERVED_PROPS = { key: !0, ref: !0, __self: !0, __source: !0 };
function jsx$1(type, config, maybeKey) {
var propName,
Expand Down Expand Up @@ -541,7 +526,15 @@ exports.memo = function (type, compare) {
compare: void 0 === compare ? null : compare
};
};
exports.startTransition = startTransition;
exports.startTransition = function (scope) {
var prevTransition = ReactCurrentBatchConfig.transition;
ReactCurrentBatchConfig.transition = {};
try {
scope();
} finally {
ReactCurrentBatchConfig.transition = prevTransition;
}
};
exports.unstable_Cache = REACT_CACHE_TYPE;
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
Expand All @@ -567,15 +560,12 @@ exports.unstable_getCacheSignal = function () {
),
dispatcher.signal);
};
exports.unstable_startTransition = startTransition;
exports.unstable_useCacheRefresh = function () {
return ReactCurrentDispatcher.current.useCacheRefresh();
};
exports.unstable_useDeferredValue = useDeferredValue;
exports.unstable_useMemoCache = function (size) {
return ReactCurrentDispatcher.current.useMemoCache(size);
};
exports.unstable_useTransition = useTransition;
exports.use = function (usable) {
return ReactCurrentDispatcher.current.use(usable);
};
Expand All @@ -586,7 +576,9 @@ exports.useContext = function (Context) {
return ReactCurrentDispatcher.current.useContext(Context);
};
exports.useDebugValue = function () {};
exports.useDeferredValue = useDeferredValue;
exports.useDeferredValue = function (value) {
return ReactCurrentDispatcher.current.useDeferredValue(value);
};
exports.useEffect = function (create, deps) {
return ReactCurrentDispatcher.current.useEffect(create, deps);
};
Expand Down Expand Up @@ -625,8 +617,10 @@ exports.useSyncExternalStore = function (
getServerSnapshot
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-canary-7118f5dd7-20230705";
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-e91142dd6-20230705";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7118f5dd7bf5f1c44d0d2944ef8ad58e423909ad
e91142dd69b0454e0d4e934c55dd541344fe32ca

0 comments on commit 70b01d0

Please sign in to comment.