Skip to content

Commit

Permalink
rename SuspenseList export to unstable_SuspenseList (#27061)
Browse files Browse the repository at this point in the history
## Summary

as we began [discussing
yesterday](#27056 (comment)),
`SuspenseList` is not actually stable yet, and should likely be exported
with the `unstable_` prefix.

the conversation yesterday began discussing this in the context of the
fb-specific packages, but changing it there without updating everywhere
else leads to test failures, so here the change is made across packages.

## How did you test this change?

```
yarn flow dom-browser
yarn test
```

DiffTrain build for [eb2c2f7](eb2c2f7)
  • Loading branch information
noahlemen committed Jul 6, 2023
1 parent 446d798 commit 7c79b2d
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 19 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e91142dd69b0454e0d4e934c55dd541344fe32ca
eb2c2f7c2cf2652a168c2b433d2989131c69754b
3 changes: 1 addition & 2 deletions compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-classic-739b12ac";
var ReactVersion = "18.3.0-www-classic-04878b24";

// ATTENTION
// When adding new symbols to this file,
Expand Down Expand Up @@ -4150,7 +4150,6 @@ exports.Profiler = REACT_PROFILER_TYPE;
exports.PureComponent = PureComponent;
exports.StrictMode = REACT_STRICT_MODE_TYPE;
exports.Suspense = REACT_SUSPENSE_TYPE;
exports.SuspenseList = REACT_SUSPENSE_LIST_TYPE;
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED =
ReactSharedInternals;
exports.cache = cache;
Expand Down
3 changes: 1 addition & 2 deletions compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-modern-d09ac638";
var ReactVersion = "18.3.0-www-modern-4c77dfb7";

// ATTENTION
// When adding new symbols to this file,
Expand Down Expand Up @@ -4115,7 +4115,6 @@ exports.Profiler = REACT_PROFILER_TYPE;
exports.PureComponent = PureComponent;
exports.StrictMode = REACT_STRICT_MODE_TYPE;
exports.Suspense = REACT_SUSPENSE_TYPE;
exports.SuspenseList = REACT_SUSPENSE_LIST_TYPE;
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED =
ReactSharedInternals;
exports.cache = cache;
Expand Down
3 changes: 1 addition & 2 deletions compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,6 @@ exports.Profiler = REACT_PROFILER_TYPE;
exports.PureComponent = PureComponent;
exports.StrictMode = REACT_STRICT_MODE_TYPE;
exports.Suspense = REACT_SUSPENSE_TYPE;
exports.SuspenseList = REACT_SUSPENSE_LIST_TYPE;
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED =
ReactSharedInternals;
exports.cache = function (fn) {
Expand Down Expand Up @@ -624,4 +623,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-classic-80690551";
exports.version = "18.3.0-www-classic-6a82fa33";
3 changes: 1 addition & 2 deletions compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,6 @@ exports.Profiler = REACT_PROFILER_TYPE;
exports.PureComponent = PureComponent;
exports.StrictMode = REACT_STRICT_MODE_TYPE;
exports.Suspense = REACT_SUSPENSE_TYPE;
exports.SuspenseList = REACT_SUSPENSE_LIST_TYPE;
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED =
ReactSharedInternals;
exports.cache = function (fn) {
Expand Down Expand Up @@ -616,4 +615,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-modern-1670571e";
exports.version = "18.3.0-www-modern-93cc7f08";
3 changes: 1 addition & 2 deletions compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@ exports.Profiler = REACT_PROFILER_TYPE;
exports.PureComponent = PureComponent;
exports.StrictMode = REACT_STRICT_MODE_TYPE;
exports.Suspense = REACT_SUSPENSE_TYPE;
exports.SuspenseList = REACT_SUSPENSE_LIST_TYPE;
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED =
ReactSharedInternals;
exports.cache = function (fn) {
Expand Down Expand Up @@ -635,7 +634,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-classic-e0d9c072";
exports.version = "18.3.0-www-classic-9c85c048";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
3 changes: 1 addition & 2 deletions compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ exports.Profiler = REACT_PROFILER_TYPE;
exports.PureComponent = PureComponent;
exports.StrictMode = REACT_STRICT_MODE_TYPE;
exports.Suspense = REACT_SUSPENSE_TYPE;
exports.SuspenseList = REACT_SUSPENSE_LIST_TYPE;
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED =
ReactSharedInternals;
exports.cache = function (fn) {
Expand Down Expand Up @@ -627,7 +626,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-modern-7fcd2222";
exports.version = "18.3.0-www-modern-d8ca5639";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -10108,7 +10108,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-739b12ac",
version: "18.3.0-www-classic-04878b24",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1306 = {
Expand Down Expand Up @@ -10139,7 +10139,7 @@ var internals$jscomp$inline_1306 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-739b12ac"
reconcilerVersion: "18.3.0-www-classic-04878b24"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1307 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -16501,7 +16501,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1791 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-d09ac638",
version: "18.3.0-www-modern-4c77dfb7",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2160 = {
Expand Down Expand Up @@ -16532,7 +16532,7 @@ var internals$jscomp$inline_2160 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-d09ac638"
reconcilerVersion: "18.3.0-www-modern-4c77dfb7"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2161 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16839,4 +16839,4 @@ exports.unstable_createEventHandle = function (type, options) {
return eventHandle;
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-www-modern-d09ac638";
exports.version = "18.3.0-www-modern-4c77dfb7";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -24344,7 +24344,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-1670571e";
var ReactVersion = "18.3.0-www-modern-93cc7f08";

// Might add PROFILE later.

Expand Down

0 comments on commit 7c79b2d

Please sign in to comment.