Prevent Jest from configuring Error source-maps

facebook · Jun 26, 2021 · 9f4627f · 9f4627f
1 parent 3599ead
commit 9f4627f
Show file tree

Hide file tree

Showing 12 changed files with 29 additions and 30 deletions.
diff --git a/...nsions/src/__tests__/__source__/__compiled__/external/ComponentWithExternalCustomHooks.js b/...nsions/src/__tests__/__source__/__compiled__/external/ComponentWithExternalCustomHooks.js
diff --git a/packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/Example.js b/packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/Example.js
diff --git a/...react-devtools-extensions/src/__tests__/__source__/__compiled__/external/InlineRequire.js b/...react-devtools-extensions/src/__tests__/__source__/__compiled__/external/InlineRequire.js
diff --git a/...ages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/ToDoList.js b/...ages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/ToDoList.js
diff --git a/...ages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/useTheme.js b/...ages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/useTheme.js
diff --git a/...tensions/src/__tests__/__source__/__compiled__/inline/ComponentWithExternalCustomHooks.js b/...tensions/src/__tests__/__source__/__compiled__/inline/ComponentWithExternalCustomHooks.js
diff --git a/packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/Example.js b/packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/Example.js
diff --git a/...s/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/InlineRequire.js b/...s/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/InlineRequire.js
diff --git a/packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/ToDoList.js b/packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/ToDoList.js
diff --git a/packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/useTheme.js b/packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/useTheme.js
diff --git a/packages/react-devtools-extensions/src/__tests__/parseHookNames-test.js b/packages/react-devtools-extensions/src/__tests__/parseHookNames-test.js
@@ -27,6 +27,11 @@ describe('parseHookNames', () => {
       .inspectHooks;
     parseHookNames = require('../parseHookNames').default;
 
+    // Jest (jest-runner?) configures Errors to automatically account for source maps.
+    // This changes behavior between our tests and the browser.
+    // To "fix" this, clear the prepareStackTrace() method on the Error object.
+    delete Error.prepareStackTrace;
+
     fetchMock.mockIf(/.+$/, request => {
       const {resolve} = require('path');
       const url = request.url;

diff --git a/packages/react-devtools-extensions/src/__tests__/updateMockSourceMaps.js b/packages/react-devtools-extensions/src/__tests__/updateMockSourceMaps.js
@@ -44,12 +44,9 @@ function compile(fileName) {
   // Generate compiled output with external source maps
   writeFileSync(
     resolve(externalDir, fileName),
-    // This comment format (//##) isn't valid;
-    // but it prevents Node from auto-applying source maps to stack traces
-    // which lets unit tests more accurately simulate browser behavior.
     transformed.code +
-      `\n//## sourceMappingURL=${fileName}.map` +
-      `\n//## sourceURL=${fileName}`,
+      `\n//# sourceMappingURL=${fileName}.map` +
+      `\n//# sourceURL=${fileName}`,
     'utf8',
   );
   writeFileSync(
@@ -61,13 +58,10 @@ function compile(fileName) {
   // Generate compiled output with external inline base64 source maps
   writeFileSync(
     resolve(inlineDir, fileName),
-    // This comment format (//##) isn't valid;
-    // but it prevents Node from auto-applying source maps to stack traces
-    // which lets unit tests more accurately simulate browser behavior.
     transformed.code +
-      '\n//## sourceMappingURL=data:application/json;charset=utf-8;base64,' +
+      '\n//# sourceMappingURL=data:application/json;charset=utf-8;base64,' +
       btoa(JSON.stringify(sourceMap)) +
-      `\n//## sourceURL=${fileName}`,
+      `\n//# sourceURL=${fileName}`,
     'utf8',
   );
 }