refactor to avoid optional chaining syntax

facebook · Oct 20, 2021 · c8a2074 · c8a2074
1 parent e287fbc
commit c8a2074
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 14 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js
@@ -2915,13 +2915,18 @@ function commitPassiveUnmountInsideDeletedTreeOnFiber(
     case LegacyHiddenComponent:
     case OffscreenComponent: {
       if (enableCache) {
-        const cache: Cache = current.memoizedState?.cachePool?.pool;
-        // Retain/release the cache used for pending (suspended) nodes.
-        // Note that this is only reached in the non-suspended/visible case:
-        // when the content is suspended/hidden, the retain/release occurs
-        // via the parent Suspense component (see case above).
-        if (cache != null) {
-          retainCache(cache);
+        if (
+          current.memoizedState !== null &&
+          current.memoizedState.cachePool !== null
+        ) {
+          const cache: Cache = current.memoizedState.cachePool.pool;
+          // Retain/release the cache used for pending (suspended) nodes.
+          // Note that this is only reached in the non-suspended/visible case:
+          // when the content is suspended/hidden, the retain/release occurs
+          // via the parent Suspense component (see case above).
+          if (cache != null) {
+            retainCache(cache);
+          }
         }
       }
       break;

diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js
@@ -2915,13 +2915,18 @@ function commitPassiveUnmountInsideDeletedTreeOnFiber(
     case LegacyHiddenComponent:
     case OffscreenComponent: {
       if (enableCache) {
-        const cache: Cache = current.memoizedState?.cachePool?.pool;
-        // Retain/release the cache used for pending (suspended) nodes.
-        // Note that this is only reached in the non-suspended/visible case:
-        // when the content is suspended/hidden, the retain/release occurs
-        // via the parent Suspense component (see case above).
-        if (cache != null) {
-          retainCache(cache);
+        if (
+          current.memoizedState !== null &&
+          current.memoizedState.cachePool !== null
+        ) {
+          const cache: Cache = current.memoizedState.cachePool.pool;
+          // Retain/release the cache used for pending (suspended) nodes.
+          // Note that this is only reached in the non-suspended/visible case:
+          // when the content is suspended/hidden, the retain/release occurs
+          // via the parent Suspense component (see case above).
+          if (cache != null) {
+            retainCache(cache);
+          }
         }
       }
       break;