Disable infinite render loop detection (#31088)

We're seeing issues with this feature internally including bugs with
sibling prerendering and errors that are difficult for developers to
action on. We'll turn off the feature for the time being until we can
improve the stability and ergonomics.

This PR does two things:
- Turn off `enableInfiniteLoopDetection` everywhere while leaving it as
a variant on www so we can do further experimentation.
- Revert #31061 which was a
temporary change for debugging. This brings the feature back to
baseline.

packages/react-dom/src/__tests__/ReactLegacyUpdates-test.js

@@ -1427,7 +1427,7 @@ describe('ReactLegacyUpdates', () => {
       }
     }
 
-    let limit = 105;
+    let limit = 55;
     await expect(async () => {
       await act(() => {
         ReactDOM.render(<EventuallyTerminating ref={ref} />, container);

packages/react-dom/src/__tests__/ReactUpdates-test.js

@@ -1542,7 +1542,7 @@ describe('ReactUpdates', () => {
       }
     }
 
-    let limit = 105;
+    let limit = 55;
     const root = ReactDOMClient.createRoot(container);
     await expect(async () => {
       await act(() => {

packages/react-reconciler/src/ReactFiberWorkLoop.js

@@ -608,13 +608,13 @@ let pendingPassiveEffectsRenderEndTime: number = -0; // Profiling-only
 let pendingPassiveTransitions: Array<Transition> | null = null;
 
 // Use these to prevent an infinite loop of nested updates
-const NESTED_UPDATE_LIMIT = 100;
+const NESTED_UPDATE_LIMIT = 50;
 let nestedUpdateCount: number = 0;
 let rootWithNestedUpdates: FiberRoot | null = null;
 let isFlushingPassiveEffects = false;
 let didScheduleUpdateDuringPassiveEffects = false;
 
-const NESTED_PASSIVE_UPDATE_LIMIT = 100;
+const NESTED_PASSIVE_UPDATE_LIMIT = 50;
 let nestedPassiveUpdateCount: number = 0;
 let rootWithPassiveNestedUpdates: FiberRoot | null = null;
 

packages/shared/ReactFeatureFlags.js

@@ -157,6 +157,12 @@ export const retryLaneExpirationMs = 5000;
 export const syncLaneExpirationMs = 250;
 export const transitionLaneExpirationMs = 5000;
 
+/**
+ * Enables a new error detection for infinite render loops from updates caused
+ * by setState or similar outside of the component owning the state.
+ */
+export const enableInfiniteRenderLoopDetection = false;
+
 // -----------------------------------------------------------------------------
 // Ready for next major.
 //
@@ -204,12 +210,6 @@ export const enableFilterEmptyStringAttributesDOM = true;
 // Disabled caching behavior of `react/cache` in client runtimes.
 export const disableClientCache = true;
 
-/**
- * Enables a new error detection for infinite render loops from updates caused
- * by setState or similar outside of the component owning the state.
- */
-export const enableInfiniteRenderLoopDetection = true;
-
 // Subtle breaking changes to JSX runtime to make it faster, like passing `ref`
 // as a normal prop instead of stripping it from the props object.
 

packages/shared/forks/ReactFeatureFlags.native-fb.js

@@ -60,7 +60,7 @@ export const enableFizzExternalRuntime = true;
 export const enableFlightReadableStream = true;
 export const enableGetInspectorDataForInstanceInProduction = true;
 export const enableHalt = false;
-export const enableInfiniteRenderLoopDetection = true;
+export const enableInfiniteRenderLoopDetection = false;
 export const enableContextProfiling = false;
 export const enableLazyContextPropagation = true;
 export const enableLegacyCache = false;

packages/shared/forks/ReactFeatureFlags.native-oss.js

@@ -51,7 +51,7 @@ export const enableFlightReadableStream = true;
 export const enableGetInspectorDataForInstanceInProduction = false;
 export const enableHalt = false;
 export const enableHiddenSubtreeInsertionEffectCleanup = false;
-export const enableInfiniteRenderLoopDetection = true;
+export const enableInfiniteRenderLoopDetection = false;
 export const enableLazyContextPropagation = true;
 export const enableContextProfiling = false;
 export const enableLegacyCache = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js

@@ -41,7 +41,7 @@ export const enableFizzExternalRuntime = true;
 export const enableFlightReadableStream = true;
 export const enableGetInspectorDataForInstanceInProduction = false;
 export const enableHalt = false;
-export const enableInfiniteRenderLoopDetection = true;
+export const enableInfiniteRenderLoopDetection = false;
 export const enableLazyContextPropagation = true;
 export const enableContextProfiling = false;
 export const enableHiddenSubtreeInsertionEffectCleanup = true;